333211 - No indication that a restart is needed when a compatibility update is applied to an app disabled addon

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Henrik Gemal]

I just checked for new updates and since I chance the update.rdf file for my extension (the maxversion string) I got the following dialog:

---------
Reliby
A compatibility update has been applied to Reliby
---------

shouldn't we say that the update will be applied at next startup?

Comment 1

[Robert Strong (they/them - no direct email)]

Was the extension disabled due to being incompatible before and was disabled? I don't recall the current precedence of all of the possible status messages for the one element used to display the possible status messages... it is entirely possible this is due to this overloading of that one element for status messages.

Comment 2

[Henrik Gemal]

(In reply to comment #1)
> Was the extension disabled due to being incompatible before and was disabled? I
> don't recall the current precedence of all of the possible status messages for
> the one element used to display the possible status messages... it is entirely
> possible this is due to this overloading of that one element for status
> messages.
> 


Sorry. Forgot to write that.

Reliby was disabled because of maxversion. I then changed maxversion in my update.rdf file to 3.0 and press check for updates. Then it said that an comp update was applied.
Perhaps we just need to write than the comp update will be applied at next restart?

Comment 3

[Robert Strong (they/them - no direct email)]

This is another one of the bugs caused by overloading a single element for all status messages... in this case the update status message and the operation type message.

Comment 4

[Robert Strong (they/them - no direct email)]

Fixed on trunk by the checkin for bug 329045. Now it will first state that a compatibility update has been applied as it did previously. Then if updates are found it will switch to the updates view and switching back it will state for the add-on Will be enabled when %APP_NAME% has been restarted. If no updates are found the global No updates were found notification will be displayed above the list with a close button for dismissing the notification. Dismissing the notification the add-on will then display Will be enabled when %APP_NAME% has been restarted.