Closed
Bug 333244
Opened 19 years ago
Closed 19 years ago
Use hardcoded binary and app name in startup script
Categories
(SeaMonkey :: UI Design, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ajschult784, Assigned: ajschult784)
Details
(Keywords: fixed-seamonkey1.1a)
Attachments
(1 file, 1 obsolete file)
|
4.89 KB,
patch
|
neil
:
review+
neil
:
superreview+
neil
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
The fix for bug 122698 stopped using the hardcoded binary name and instead sniffs out the binary name from the script name and takes the script name to be the app name (because the Makefile search/replace does not handle the app name). This breaks symlinking to the script with a different name. The better solution would be to have the Makefile search/replace the binary and app name.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #217685 -
Flags: superreview?(neil)
Attachment #217685 -
Flags: review?(neil)
|
|
Assignee | |
Comment 2•19 years ago
|
||
OK, this patches the parallel-universe Makefile in suite/ and adds MOZ_NO_REMOTE handling to override the new behavior. The MOZ_NO_REMOTE handling matches the documented behavior (setting MOZ_NO_REMOTE=1 disables remote) but not what the backend code does (setting MOZ_NO_REMOTE to anything, including nothing disables remote).
Attachment #217685 -
Attachment is obsolete: true
Attachment #217687 -
Flags: superreview?(neil)
Attachment #217687 -
Flags: review?(neil)
Attachment #217685 -
Flags: superreview?(neil)
Attachment #217685 -
Flags: review?(neil)
|
||
Updated•19 years ago
|
Attachment #217687 -
Flags: superreview?(neil)
Attachment #217687 -
Flags: superreview+
Attachment #217687 -
Flags: review?(neil)
Attachment #217687 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
fixed
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•19 years ago
|
Attachment #217687 -
Flags: approval-branch-1.8.1?(neil)
|
|
||
Updated•19 years ago
|
Attachment #217687 -
Flags: approval-branch-1.8.1?(neil) → approval-branch-1.8.1+
|
|
Assignee | |
Updated•19 years ago
|
Keywords: fixed-seamonkey1.1a
You need to log in
before you can comment on or make changes to this bug.
Description
•