synchronous X calls in fast-path GTK2 native theme rendering

RESOLVED WORKSFORME

Status

()

defect
--
critical
RESOLVED WORKSFORME
13 years ago
12 years ago

People

(Reporter: dbaron, Assigned: roc)

Tracking

({perf})

Trunk
x86
Linux
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

There are synchronous XGetGeometry calls even in the fast-path GTK2 native theme rendering, as I described on bug 327878 comment 16.  We need to work around the XGetGeometry issue without depending on the GDK API that was just added (see bug 327878 comment 21)
I'm actually a bit surprised by this one, because gdk_pixmap_foreign_new_for_display should only be called once per widget update in most cases, to get a Gdk pixmap for the backbuffer, the first time we draw a native widget into it. After that gdk_pixmap_lookup_for_display should be succeeding until the next time. And one round-trip per widget update shouldn't be eating 25% of our time ... maybe...

I'm looking into it.
Looks like roc attached a patch for this (and that) to bug 333250.
Assignee: nobody → roc
For the record, gdk_pixmap_lookup_for_display was always failing, because pixmap_foreign_new_for_display was creating a proxy and then after we draw one widget with it, we drop our reference to the proxy and it gets deleted right away :-(.
Flags: blocking1.9?
Pretty sure this was fixed by bug 333250.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → WORKSFORME

Updated

12 years ago
Flags: in-testsuite-
Flags: blocking1.9?
You need to log in before you can comment on or make changes to this bug.