333249 - synchronous X calls in fast-path GTK2 native theme rendering

Status: RESOLVED WORKSFORME

(Core :: Graphics, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

There are synchronous XGetGeometry calls even in the fast-path GTK2 native theme rendering, as I described on bug 327878 comment 16.  We need to work around the XGetGeometry issue without depending on the GDK API that was just added (see bug 327878 comment 21)

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm actually a bit surprised by this one, because gdk_pixmap_foreign_new_for_display should only be called once per widget update in most cases, to get a Gdk pixmap for the backbuffer, the first time we draw a native widget into it. After that gdk_pixmap_lookup_for_display should be succeeding until the next time. And one round-trip per widget update shouldn't be eating 25% of our time ... maybe...

I'm looking into it.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Looks like roc attached a patch for this (and that) to bug 333250.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

For the record, gdk_pixmap_lookup_for_display was always failing, because pixmap_foreign_new_for_display was creating a proxy and then after we draw one widget with it, we drop our reference to the proxy and it gets deleted right away :-(.

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Pretty sure this was fixed by bug 333250.