Closed Bug 333304 Opened 14 years ago Closed 14 years ago

useless null check of aLocation in nsComponentManagerImpl::RegisterComponentWithType

Categories

(Core :: XPCOM, defect, trivial)

x86
Linux
defect
Not set
trivial

Tracking

()

RESOLVED INVALID

People

(Reporter: timeless, Unassigned)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

found by coverity

nsComponentManagerImpl::RegisterComponentWithTyp is internal and neither consumer will pass a null pointer for aLocation.
in fact, the code could probably be changed to pass around an object to save on strlen calls.
Status: UNCONFIRMED → NEW
Ever confirmed: true
RegisterComponentWithType turned out to be a method defined on nsIComponentManagerObsolete interface, so it's not really internal and should do the null-check.

Incorrect signature for this method (and others - see bug 333307) is what confused matters.
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
Summary: useless null check of aLocation in nsComponentManagerImpl::RegisterComponentWithTyp → useless null check of aLocation in nsComponentManagerImpl::RegisterComponentWithType
You need to log in before you can comment on or make changes to this bug.