333306 - Crash with pragma statements that return values

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[Matthew Gertner]

I got a crash when using PRAGMA user_version. The reason is that mozStorageStatement retrieves the name for each column in a result set and storages it in an array (which, as far as I can see, is never used for anything... but I might be missing something). In the case of PRAGMA user_version (and, I assume, other PRAGMA statements that return values), the name is NULL.

Comment 1

[Matthew Gertner]

Attachment: Adds a check to prevent crashing when the column name is NULL

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 217725 [details] [diff] [review]
Adds a check to prevent crashing when the column name is NULL

We should still append something to mColumnNames -- an empty string or even a string with the null bit set.

Comment 3

[Matthew Gertner]

Attachment: Adds an empty string if no column name is available

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 218851 [details] [diff] [review]
Adds an empty string if no column name is available

Looks good, thanks for making the change!

Comment 5

[Matthew Gertner]

I requested 1.8.1 approval since we won't be able to run on FF 2.0 without this.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Does this need to be checked in?

Comment 7

[Matthew Gertner]

Yes.

Comment 8

[Brett Wilson]

This shouldn't be checked in until bug 338155 has landed, which is the new version of sqlite.

Comment 9

[Brett Wilson]

Fixed on trunk and 1.8 branch.