333356 - cellmap dead code & 0 deref

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect)

Description

[Bernd]

fix for two coverity warnings

Comment 1

[Bernd]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 217771 [details] [diff] [review]
patch

>Index: nsCellMap.cpp

>+    // at the right edge of the table as we checked the corner before

Can we add an assert to that effect?  That is, I assume we'd assert !aIsBottomRight here?

r+sr=bzbarsky with that.

Comment 3

[Bernd]

fix checked in

Comment 4

[Bernd]

Comment on attachment 217771 [details] [diff] [review]
patch

I checked it with boris comments http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsCellMap.cpp&branch=&root=/cvsroot&subdir=mozilla/layout/tables&command=DIFF_FRAMESET&rev1=3.101&rev2=3.102

Comment 5

[Daniel Veditz [:dveditz]]

roc, bz: is this wanted/appropriate for 1.8.0.x also?

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 217771 [details] [diff] [review]
patch

approved for 1.8.0 branch, a=dveditz for drivers

Comment 7

[Bernd]

fix checked in into branches

Comment 8

[kitchin]

>Can we add an assert to that effect? That is, I assume we'd assert
>!aIsBottomRight here?
> r+sr=bzbarsky with that.

The patches checked in do not have the assert.

Comment 9

[Bernd]

>The patches checked in do not have the assert.

and thats intentional!!! Nobody is debugging layout on a branch, the trunk where people debug has the assert see http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsCellMap.cpp&branch=&root=/cvsroot&subdir=mozilla/layout/tables&command=DIFF_FRAMESET&rev1=3.101&rev2=3.102
 and yes, I did learn my lesson from bug 315210. 
But please go and put in the assert if you can handle the consequences I will certainly not do it.

Comment 10

[Jay Patel [:jay]]

Any easy way to verify this fix?  Any testcases or steps associated with the Coverity warnings mentioned?

Comment 11

[timeless]

just get a coverity account and ask it if it complains about the relevant files. for kicks, find a run from before this bug was filed and verify that coverity indeed lists it as a complaint.