33349 - Directory name in Create Directory dialog needs to be left aligned

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P3)

Description

[Henrik Gemal]

If you press Browse... on the Select Type dialog you're presented with a Select 
a directory dialog.
This dialog needs to be fixed with the following:
- Directory name needs to be left aligned
- Title of dialog should just be Create Directory. The "?" looks a bit odd.
- Text should something like:
The selected folder:
c:\program files\mozilla\
does not exist. Do you want the folder to be created?

Comment 1

[Henrik Gemal]

I meant the dialog that appears when the selected directory doesn't exist.

The following still needs to be fixed:
- Directory name needs to be left aligned

Comment 2

[Henrik Gemal]

Is this because of the:
lstrcpy(szBufTemp, "\n\n    ");
in
http://lxr.mozilla.org/seamonkey/source/xpinstall/wizard/windows/setup/dialogs.c
#399

it should just be:
lstrcpy(szBufTemp, "\n\n");

Comment 3

[Henrik Gemal]

Attachment: Diff to fix indent problem

Comment 4

[Henrik Gemal]

Since this is such an easy fix, perhaps someone (Blake) could check it in...?

Comment 5

[timeless]

The patch rotted. s/399/401/
401 lstrcpy(szBufTemp, "\n\n    ");
402 lstrcat(szBufTemp, szBuf);
403 RemoveBackSlash(szBufTemp);
404 lstrcat(szBufTemp, "\n\n");
405 wsprintf(szBufTemp2, szMsgCreateDirectory, szBufTemp);
Bredan is wsprintf something that risks buffer overruns and is there a better 
function?

Comment 6

[Brendan Eich [:brendan]]

Argh, Windows-specific code!  Yes, PR_snprintf should be used instead of any 
Morris-worm-recapitulating *sprintf.

/be

Comment 7

[Brendan Eich [:brendan]]

We need faster patch uptake here and in bug 33353, to avoid bitrot....

/be

Comment 8

[Sean Su]

Patch checked in.  Sorry about the delay.  I will try to be more ontop of patches.

We're not using PR_* functions because this is platform specific, native windows
code.  Since this is only the windows installer, and not a browser, I'm not too
concerned about buffer overruns (except that I am aware of the possibility and
have taken steps to minimize it).

However, if someone feels strongly different, I can try porting the PR_*
functions used in the browser code.  File a bug against the windows installer.

Comment 9

[Henrik Gemal]

Just found two other places:

http://lxr.mozilla.org/mozilla/source/xpinstall/wizard/windows/setup/dialogs.c#7
79
http://lxr.mozilla.org/mozilla/source/xpinstall/wizard/windows/setup/dialogs.c#7
94

Comment 10

[Henrik Gemal]

Attachment: diff to fix indent

Comment 11

[Sean Su]

looks good.  mo,r=ssu

Comment 12

[Scott MacGregor]

sr=mscott

Comment 13

[Sean Su]

fix checked in.

Comment 14

[Henrik Gemal]

installer build 2001020204