Closed Bug 333623 Opened 15 years ago Closed 15 years ago

about:blank's favicon draggable from location bar but not from tabs

Categories

(Camino Graveyard :: Drag & Drop, defect)

PowerPC
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: froodian, Assigned: bugzilla-graveyard)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

The favicon for about:blank is draggable (like all other pages) from the location bar, but isn't from tabs.  Either behavior would be OK, but they should definitely match.

I'm in favor of disabling dragging in the location bar (rather than enabling it in the tabs), since I can't think of a reason why anybody would want to drag and drop a blank page.
I'm actually in favor of the other way, enabling drag&drop on the tabs. An icon is an icon is an icon and we shouldn't treat it better just because it's not a "standard" page.

That said, how are all our other about: pages treated?
I see what you mean about keeping icons' behavior consistent regardless of the page.

All other about: pages act like regular webpages.
(In reply to comment #2)
> All other about: pages act like regular webpages.

Because all other about: pages have content, like regular web pages.
(In reply to comment #3)
> Because all other about: pages have content, like regular web pages.
> 

Yes, they do. I just don't see why we should "discriminate" simply because about:blank doesn't have content. It's unexpected for the (albeit crazy) users who try to do this.
The icon is dragable as a proxy for the location, and about blank *has* no location. It's already treated differently in that the url is displayed blank, because from the user's perspective there is nothing there. Having a proxy for nothing doesn't make sense (see for example TextEdit, which don't even display a proxy icon for an unsaved new document, for the same reason)
Assignee: mikepinkerton → bugzilla
Status: NEW → ASSIGNED
Attachment #224331 - Flags: review?(hwaara)
Comment on attachment 224331 [details] [diff] [review]
stops drag of icon if about:blank is the current URL

>-  if (!urlString)
>+  // don't allow dragging of proxy icon for empty pages
>+  if ((!urlString) || [MainController isBlankURL:urlString])
>     return;

Drop the extra parenthesis for !urlString please.
Attachment #224331 - Flags: review?(hwaara) → review+
Comment on attachment 224331 [details] [diff] [review]
stops drag of icon if about:blank is the current URL

sr=pink?

cl
Attachment #224331 - Flags: superreview?(mikepinkerton)
Comment on attachment 224331 [details] [diff] [review]
stops drag of icon if about:blank is the current URL

sr=pink
Attachment #224331 - Flags: superreview?(mikepinkerton) → superreview+
Whiteboard: [needs checkin]
Fixed trunk and 1.8 branch.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: fixed1.8
Resolution: --- → FIXED
Whiteboard: [needs checkin]
You need to log in before you can comment on or make changes to this bug.