333637 - PR_CreateProcess() function drops empty string parameters

Status: RESOLVED FIXED

(NSPR :: NSPR, defect)

Description

[Aleksey Sanin]

E.g. there is no way to execute the following command line:

something.exe "" something.txt

because assembleCmdLine() function in ntmisc.c file creates the following command line:

something.exe  something.txt

The patch is coming.

Comment 1

[Aleksey Sanin]

Attachment: Patch

Comment 2

[Wan-Teh Chang]

Comment on attachment 218094 [details] [diff] [review]
Patch 

r=wtc.  Thanks for the patch.  Have you tested this patch?
(I may be too busy to test the patch.)

>+        if ((**arg) == '\0' || strpbrk(*arg, " \f\n\r\t\v")) {
>             argNeedQuotes = 1;
>         }

I'm curious why you put parentheses around **arg.

Comment 3

[Aleksey Sanin]

hm... it looks better? :) yes, I did test it though not very extensivly.

Comment 4

[Kai Engert (:KaiE:)]

is this ready for check in?

Comment 5

[Wan-Teh Chang]

Yes, it is.  Sorry, I forgot to check in this patch.

I just checked in this patch on the NSPR trunk for NSPR 4.7.

Checking in ntmisc.c;
/cvsroot/mozilla/nsprpub/pr/src/md/windows/ntmisc.c,v  <--  ntmisc.c
new revision: 3.22; previous revision: 3.21
done

Comment 6

[Wan-Teh Chang]

Attachment: Patch (as checked in)