333673 - document.implementation != document.implementation

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Erik Arvidsson]

Why doesn't multiple read of document.implementation return the same object?

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: parity with other engines

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 396221 [details] [diff] [review]
parity with other engines

>+  if (mDOMImplementation) {
>+    NS_ADDREF(*aImplementation = mDOMImplementation);
>+    return NS_OK;
>+  }
>   nsCOMPtr<nsIURI> uri;
>   NS_NewURI(getter_AddRefs(uri), "about:blank");
>   NS_ENSURE_TRUE(uri, NS_ERROR_OUT_OF_MEMORY);
>   PRBool hasHadScriptObject = PR_TRUE;
>   nsIScriptGlobalObject* scriptObject =
>     GetScriptHandlingObject(hasHadScriptObject);
>   NS_ENSURE_STATE(scriptObject || !hasHadScriptObject);
>   *aImplementation = new nsDOMImplementation(scriptObject, uri, uri,
>                                              NodePrincipal());
>   if (!*aImplementation) {
>     return NS_ERROR_OUT_OF_MEMORY;
>   }
> 
>+  mDOMImplementation = *aImplementation;
>   NS_ADDREF(*aImplementation);

I think I'd rather see this as:

  if (!mDOMImplementation) {
    nsCOMPtr<nsIURI> uri;
    NS_NewURI(getter_AddRefs(uri), "about:blank");
    NS_ENSURE_TRUE(uri, NS_ERROR_OUT_OF_MEMORY);
    PRBool hasHadScriptObject = PR_TRUE;
    nsIScriptGlobalObject* scriptObject =
      GetScriptHandlingObject(hasHadScriptObject);
    NS_ENSURE_STATE(scriptObject || !hasHadScriptObject);
    mDOMImplementation = new nsDOMImplementation(scriptObject, uri, uri,
                                                 NodePrincipal());
    if (!mDOMImplementation) {
      return NS_ERROR_OUT_OF_MEMORY;
    }
  }

  NS_ADDREF(*aImplementation = mDOMImplementation);

  return NS_OK;

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: v2

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/ba0ca9a1c14c