333679 - certutil adds 3 months to user-specified validity period

Status: RESOLVED FIXED

(NSS :: Tools, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

certutil has a -v option that specifies the validity period in months.
The usage message says that the default value is 3, but that is not 
exactly right.

The default value is zero, and certutil always adds 3 to whatever value 
is given (including the default value).

certutil should have a default that is 3 (to match the usage), but when 
the user specifies a value, that value given should be honored without addition.

patch forthcoming

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch v1

Neil, please review.

Comment 2

[Julien Pierre]

I think there was a reason for those extra 3 months, but I can't remember what it was. all.sh should definitely be tested with the patch before reviewing. I wouldn't be surprised if some tests depended on it.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

(In reply to comment #2)
> all.sh should definitely be tested with the patch before reviewing. 
> I wouldn't be surprised if some tests depended on it.

all.sh passes with this change in place (on my windows box with OBJD build)

Comment 4

[Neil Williams]

Comment on attachment 218134 [details] [diff] [review]
patch v1

Looks good.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Checked in on trunk
Checking in certutil.c; new revision: 1.100; previous revision: 1.99

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Checked in on branch.
Checking in certutil.c;  new revision: 1.97.2.3; previous revision: 1.97.2.2

Thanks for the review, Neil.