bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

certutil adds 3 months to user-specified validity period

RESOLVED FIXED in 3.11.1

Status

NSS
Tools
P2
normal
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: Nelson Bolyard (seldom reads bugmail), Assigned: Nelson Bolyard (seldom reads bugmail))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

certutil has a -v option that specifies the validity period in months.
The usage message says that the default value is 3, but that is not 
exactly right.

The default value is zero, and certutil always adds 3 to whatever value 
is given (including the default value).

certutil should have a default that is 3 (to match the usage), but when 
the user specifies a value, that value given should be honored without addition.

patch forthcoming
(Assignee)

Updated

12 years ago
Status: NEW → ASSIGNED
Priority: -- → P2
(Assignee)

Comment 1

12 years ago
Created attachment 218134 [details] [diff] [review]
patch v1

Neil, please review.
Attachment #218134 - Flags: review?

Comment 2

12 years ago
I think there was a reason for those extra 3 months, but I can't remember what it was. all.sh should definitely be tested with the patch before reviewing. I wouldn't be surprised if some tests depended on it.
(Assignee)

Updated

12 years ago
Attachment #218134 - Flags: review? → review?(neil.williams)
(Assignee)

Comment 3

12 years ago
(In reply to comment #2)
> all.sh should definitely be tested with the patch before reviewing. 
> I wouldn't be surprised if some tests depended on it.

all.sh passes with this change in place (on my windows box with OBJD build)

Comment 4

12 years ago
Comment on attachment 218134 [details] [diff] [review]
patch v1

Looks good.
Attachment #218134 - Flags: review?(neil.williams) → review+
(Assignee)

Comment 5

12 years ago
Checked in on trunk
Checking in certutil.c; new revision: 1.100; previous revision: 1.99
(Assignee)

Comment 6

12 years ago
Checked in on branch.
Checking in certutil.c;  new revision: 1.97.2.3; previous revision: 1.97.2.2

Thanks for the review, Neil.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.