Closed
Bug 333693
Opened 18 years ago
Closed 18 years ago
Hopefully useless comparison in nsFtpState::Init
Categories
(Core Graveyard :: Networking: FTP, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: timeless, Assigned: sciguyryan)
References
(Blocks 1 open bug, )
Details
(Keywords: coverity)
Attachments
(1 file)
946 bytes,
patch
|
darin.moz
:
review-
darin.moz
:
superreview-
|
Details | Diff | Splinter Review |
If i'm wrong, this is a crash. If i'm right, can save a comoparison by removing the first null check. Since darin wrote the latest string class, he can confirm :).
Updated•18 years ago
|
Assignee: darin → nobody
Comment 1•18 years ago
|
||
Yeah, the MOZILLA_INTERNAL_API version of BeginWriting() never returns null.
Assignee | ||
Comment 2•18 years ago
|
||
Remove |fwdPtr| from the comparison and just check for a slash.
Assignee: nobody → sciguyryan+bugzilla
Status: NEW → ASSIGNED
Attachment #239683 -
Flags: superreview?(darin)
Attachment #239683 -
Flags: review?(bzbarsky)
Comment 3•18 years ago
|
||
Comment on attachment 239683 [details] [diff] [review] Patch v1 I think this is as good as candidate for r+sr as they come. ;)
Attachment #239683 -
Flags: review?(bzbarsky) → review?(darin)
Comment 4•18 years ago
|
||
Comment on attachment 239683 [details] [diff] [review] Patch v1 According to nsTSubstring.h, BeginWriting may return null.
Assignee | ||
Comment 5•18 years ago
|
||
(In reply to comment #4) > (From update of attachment 239683 [details] [diff] [review] [edit]) > According to nsTSubstring.h, BeginWriting may return null. > Guess that means this null check is required then?
Comment 6•18 years ago
|
||
Comment on attachment 239683 [details] [diff] [review] Patch v1 yeah, i think so.
Attachment #239683 -
Flags: superreview?(darin)
Attachment #239683 -
Flags: superreview-
Attachment #239683 -
Flags: review?(darin)
Attachment #239683 -
Flags: review-
Assignee | ||
Comment 7•18 years ago
|
||
By Darin's last comment this bug is probably invalid.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → INVALID
Updated•6 years ago
|
Blocks: coverity-analysis
Updated•3 months ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•