333693 - Hopefully useless comparison in nsFtpState::Init

Status: RESOLVED INVALID

(Core Graveyard :: Networking: FTP, defect)

Description

[timeless]

If i'm wrong, this is a crash. If i'm right, can save a comoparison by removing the first null check. Since darin wrote the latest string class, he can confirm :).

Comment 1

[Darin Fisher]

Yeah, the MOZILLA_INTERNAL_API version of BeginWriting() never returns null.

Comment 2

[Ryan Jones-Ward [:sciguyryan]]

Attachment: Patch v1

Remove |fwdPtr| from the comparison and just check for a slash.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 239683 [details] [diff] [review]
Patch v1

I think this is as good as candidate for r+sr as they come.  ;)

Comment 4

[Darin Fisher]

Comment on attachment 239683 [details] [diff] [review]
Patch v1

According to nsTSubstring.h, BeginWriting may return null.

Comment 5

[Ryan Jones-Ward [:sciguyryan]]

(In reply to comment #4)
> (From update of attachment 239683 [details] [diff] [review] [edit])
> According to nsTSubstring.h, BeginWriting may return null.
> 

Guess that means this null check is required then?

Comment 6

[Darin Fisher]

Comment on attachment 239683 [details] [diff] [review]
Patch v1

yeah, i think so.

Comment 7

[Ryan Jones-Ward [:sciguyryan]]

By Darin's last comment this bug is probably invalid.