333701 - Hopefully useless null check in nsPluginStreamListenerPeer::Initialize

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[timeless]

The main codepath unconditionally dereferences aURL, the debug path which coverity considered today conditionally dereferenecs which caused coverity to warn about the unconditional deref.

if this was a real crash, we'd have heard about it, let's remove the null check :).

Comment 1

[Adam Guthrie]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 222147 [details] [diff] [review]
patch

this will fail to compile if PLUGIN_LOGGING is defined, no?

Comment 3

[Adam Guthrie]

Attachment: patch v2

Yes, you're right. (I should really test things before submitting them.) I don't know if this will stop coverity from complaining... it might.

Comment 4

[(no longer active)]

ispiked, I noticed that you haven't requested a review on your patch yet.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 222222 [details] [diff] [review]
patch v2

This never had r? set on it. Per ispiked on IRC, requesting review from biesi.

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 222222 [details] [diff] [review]
patch v2

the additional line of context showing the unconditional NS_ADDREF would've been nice

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 222222 [details] [diff] [review]
patch v2

Simple fix for an issue raised by coverity.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 222222 [details] [diff] [review]
patch v2

a=beltzner for 1.9

Comment 9

[Reed Loden [:reed]]

Checking in modules/plugin/base/src/nsPluginHostImpl.cpp;
/cvsroot/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp,v  <--  nsPluginHostImpl.cpp
new revision: 1.593; previous revision: 1.592
done