Closed Bug 333701 Opened 14 years ago Closed 12 years ago

Hopefully useless null check in nsPluginStreamListenerPeer::Initialize

Categories

(Core :: Plug-ins, defect, trivial)

x86
Linux
defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla1.9beta3

People

(Reporter: timeless, Assigned: ispiked)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity)

Attachments

(1 file, 1 obsolete file)

1.18 KB, patch
Biesinger
: review+
beltzner
: approval1.9+
Details | Diff | Splinter Review
The main codepath unconditionally dereferences aURL, the debug path which coverity considered today conditionally dereferenecs which caused coverity to warn about the unconditional deref.

if this was a real crash, we'd have heard about it, let's remove the null check :).
Attached patch patch (obsolete) — Splinter Review
Comment on attachment 222147 [details] [diff] [review]
patch

this will fail to compile if PLUGIN_LOGGING is defined, no?
Attachment #222147 - Flags: review-
Attached patch patch v2Splinter Review
Yes, you're right. (I should really test things before submitting them.) I don't know if this will stop coverity from complaining... it might.
Attachment #222147 - Attachment is obsolete: true
Assignee: darin → nobody
ispiked, I noticed that you haven't requested a review on your patch yet.
Comment on attachment 222222 [details] [diff] [review]
patch v2

This never had r? set on it. Per ispiked on IRC, requesting review from biesi.
Attachment #222222 - Flags: review?(cbiesinger)
Comment on attachment 222222 [details] [diff] [review]
patch v2

the additional line of context showing the unconditional NS_ADDREF would've been nice
Attachment #222222 - Flags: review?(cbiesinger) → review+
Comment on attachment 222222 [details] [diff] [review]
patch v2

Simple fix for an issue raised by coverity.
Attachment #222222 - Flags: approval1.9?
Assignee: nobody → ispiked
Comment on attachment 222222 [details] [diff] [review]
patch v2

a=beltzner for 1.9
Attachment #222222 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
Checking in modules/plugin/base/src/nsPluginHostImpl.cpp;
/cvsroot/mozilla/modules/plugin/base/src/nsPluginHostImpl.cpp,v  <--  nsPluginHostImpl.cpp
new revision: 1.593; previous revision: 1.592
done
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M11
You need to log in before you can comment on or make changes to this bug.