Livemark Service leaking nsRDFResource and RDFServiceImpl references

RESOLVED FIXED in Firefox 2 alpha2

Status

()

RESOLVED FIXED
13 years ago
9 years ago

People

(Reporter: mozilla, Assigned: mozilla)

Tracking

({fixed1.8.1, memory-leak})

2.0 Branch
Firefox 2 alpha2
fixed1.8.1, memory-leak
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

13 years ago
When the Livemark Service is instantiated during a session, bloat.log reveals 1 leaked RDFServiceImpl and 10 leaked nsRDFResource references
(Assignee)

Comment 1

13 years ago
Created attachment 218203 [details]
Bloat log when nsLivemarkService is NOT instantiated
(Assignee)

Comment 2

13 years ago
Created attachment 218204 [details]
Bloat log when nsLivemarkService IS instantiated (note 11 leaked refs mentioned in original comment)
(Assignee)

Comment 3

13 years ago
Created attachment 218205 [details] [diff] [review]
Patch to change the responsible loose pointers to member nsCOMPtrs
Attachment #218205 - Flags: superreview?(bryner)
Attachment #218205 - Flags: review?(darin)
Attachment #218205 - Flags: superreview?(bryner) → superreview+

Updated

13 years ago
Attachment #218205 - Flags: review?(darin) → review+
(Assignee)

Comment 4

13 years ago
Landed on branch & trunk.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
(Assignee)

Comment 5

13 years ago
Created attachment 218209 [details]
For the completeness, the bloat log after patch, with nsLivemarkService instantated and those 11 RDF... leaks gone

Updated

13 years ago
Keywords: mlk
(Assignee)

Updated

13 years ago
Blocks: 330063
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.