333835 - Fix temp file problem in SQLITE on OS/2

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, defect)

Description

[Peter Weilbacher]

The SQLITE backend produces many sqlite* files in %TEMP% when browsing with a Places enabled Firefox build. That is because of a bug in the SQLITE platform code for OS/2.

Comment 1

[Peter Weilbacher]

Attachment: Fix tempfile problem (+ cleanup), patch by Daniel Kruse

This patch to os_os2.c fixes the temp file problem, and also cleans up the code with respect to whitespace and return code readability.

I suspect the same patch will end up in upstream SQLITE soon, not sure if we still need the patch here.

Comment 2

[Mike Kaply [:mkaply]]

Comment on attachment 218265 [details] [diff] [review]
Fix tempfile problem (+ cleanup), patch by Daniel Kruse

r=mkaply - this is OS/2 only, so I'll just check it in.

Comment 3

[Brett Wilson]

Please check this patch into db/sqlite3 along with the other patches and add documentation to the end of README.MOZILLA in that directory.

We're going to upgrading sqlite, and I will forget this patch if you don't do this. If this is a generic sqlite problem, you should send your patch to them so we don't have to manage these patches.

Comment 4

[Peter Weilbacher]

brettw, I learned in the meantime that the OS/2 files did not yet make it into the SQLite repository. So I would guess if you sync with them you wouldn't overwrite the files? If still required you could put this at the end of README.MOZILLA:


While updating do not remove the files os_os2.c and os_os2.h.

-- Peter Weilbacher <[e-mail]> 05/2006

Comment 5

[Brett Wilson]

Can you make a patch and do that? I'll forget and I'm not going to be doing this for a few days.

Comment 6

[Peter Weilbacher]

Attachment: Add comment to README.MOZILLA

Whoever checks in these changes: can you please also add this comment to README.MOZILLA?
The OS/2 files should make it into SQLite hopefully soon, but until then this comment should be there I guess.

Comment 7

[Peter Weilbacher]

Attachment: changes to os.h

Bloody hell, it seems this came too late. The update already overwrote the previous OS/2 changes in os.h. :-( To get it to build again on OS/2 we need this patch anew.

Comment 8

[Brett Wilson]

(In reply to comment #7)
> Bloody hell, it seems this came too late. The update already overwrote the
> previous OS/2 changes in os.h. :-( To get it to build again on OS/2 we need
> this patch anew.

Please check in the patch as I requested in comment 3 or it will keep getting overwritten every time.

Comment 9

[Peter Weilbacher]

brettw, I would love to but nobody wants to give me sr+ in bug 319955.

In the meantime, mkaply, can you do something about it?

Comment 10

[Mike Kaply [:mkaply]]

Everything above is checked in.

Comment 11

[Peter Weilbacher]

Thanks, Mike!