Closed Bug 334069 Opened 20 years ago Closed 20 years ago

Improve task list performance

Categories

(Calendar :: Lightning Only, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jminta, Assigned: jminta)

Details

Attachments

(1 file)

I'm currently auditing calIObservers to try to weed out the ones that rebuild their entire displays when items are added/modified/deleted. These extra calls to getItems() really hurt performance. calendar-todo-list.xml is one such guilty party. Patch forthcoming.
Attached patch patch v1Splinter Review
Patch makes it so the task list actually listens to batches, and also will only rebuild its display when extreme changes have been made (calendars added/removed or batches ending)
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #218483 - Flags: first-review?(dmose)
Comment on attachment 218483 [details] [diff] [review] patch v1 Looks good! >+ <body><![CDATA[ >+ // don't use for each, because childNodes is special If you could make this comment slightly more detailed, that'd be great. r=dmose
Attachment #218483 - Flags: first-review?(dmose) → first-review+
Patch checked in since this is Lightning only
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: