334130 - Selecting "Bookmarks | Organize Bookmarks" when the organizer is already open should not change the selected folder

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Ryuichi KUBUKI]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060415 Firefox/3.0a1

1. Open the Places window by the menu Bookmarks | Organize Bookmarks
2. Select Bookmarks Menu in the left tree in Places
3. Select the menu Bookmarks | Organize Bookmarks in the browser again

Actual results:
The Places window shows History

Expected results:
The Places window shows Bookmarks Menu


It's like this for a couple of days (non-Cairo trunk without an extension).

Comment 1

[Andreas Grillenberger]

I can't confirm this, also not on a non-cairo build. At mine, it shows what it should show - Bookmarks, not history.

Comment 2

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #0)
>
I see this happen indeed.

Comment 3

[Phil Ringnalda (:philor)]

I can only reproduce in an old profile: in a newly created profile, or a newly imported one, Bookmarks Menu is always selected (despite the odd fact that it's the first item in a newly created profile, and History is first in a newly imported one).

Comment 4

[Ryuichi KUBUKI]

(In reply to comment #3)
> I can only reproduce in an old profile: in a newly created profile, or a newly
> imported one, Bookmarks Menu is always selected (despite the odd fact that it's
> the first item in a newly created profile, and History is first in a newly
> imported one).

In my case, I just installed a new trunk over a couple days old trunk build which worked without a problem and now I get this behaviour, probably at the same timeframe when the behaviour of pressing the Places buttuon in the toolbar was changed to show a search box.

Comment 5

[Ryuichi KUBUKI]

(In reply to comment #1)
> I can't confirm this, also not on a non-cairo build. At mine, it shows what it
> should show - Bookmarks, not history.
> 

Hmm I still have this on a Cairo build. Right now I can't make a new profile, can someone test it?

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060418 Firefox/3.0a1

Comment 6

[Asaf Romano (gone)]

Morphing this a bit to the remaining issue.

Comment 7

[Asaf Romano (gone)]

Attachment: patch

Comment 8

[(not reading, please use [e-mail] instead)]

Comment on attachment 254607 [details] [diff] [review]
patch

r=sspitzer

but since no one is calling with aForcePlace == true, why have it?  Or, do you expect us to use that functionality in future Fx 3 work?

Comment 9

[Asaf Romano (gone)]

I left that in for both potential future Fx 3 work/extensions.

Comment 10

[Asaf Romano (gone)]

mozilla/browser/base/content/browser-places.js 1.27
mozilla/browser/base/content/browser-sets.inc 1.92

Comment 11

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv