334152 - Rework _get_local_filename in Attachment.pm to a public routine

Status: NEW

(Bugzilla :: Attachments & Requests, enhancement)

Description

[Teemu Mannermaa (:wicked)]

Currently _get_local_filename subroutine in Bugzilla/Attachment.pm is marked as internal (hence the _ in front of the name). Unfortunately, the information it provides is needed outside of Attachment.pm, like in view routine of attachment.cgi that right now has duplicated the filename generation code (eww!).

To remove the code duplication, it would be nice to rework this to be a public routine and use it everywhere needed.

Comment 1

[Frédéric Buclin]

I agree!

Comment 2

[Frédéric Buclin]

We are in "soft freeze" mode to prepare 3.0 RC1.

Comment 3

[Max Kanat-Alexander]

Bugzilla 3.2 is now frozen. Only enhancements blocking 3.2 or specifically approved for 3.2 may be checked in to the 3.2 branch. If you would like to nominate your enhancement for Bugzilla 3.2, set the "blocking3.2" flag to "?". Then, either the target milestone will be changed back, or the blocking3.2 flag will be granted, if we will accept this enhancement for Bugzilla 3.2.

This particular bug has not been touched in over eight months, and thus is being retargeted to "---" instead of "Bugzilla 4.0". If you believe this is a mistake, feel free to retarget it to Bugzilla 4.0.