334161 - Upgrade ChatZilla to 0.9.74 on Gecko 1.8 branch

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8) Gecko/20060415 SeaMonkey/1.1a] (nightly) (W98SE)

Currently, v0.9.70 gives the following warning when it's not already in XUL.mfl:
{{
Warning: function ts_serialize does not always return a value
Source File: chrome://chatzilla/content/lib/js/text-serializer.js
Line: 201
Source Code:
}
}}

Upgrading to current release would seem fine.

Comment 1

[James Ross]

Are you suggesting upgrading the branch by 2 revisions just for a strict JS warning? Also, what's the deal with locale changes on the 1.8 branch?

Comment 2

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> Are you suggesting upgrading the branch by 2 revisions just for a strict JS

Not really, that was a simple note.
My suggestion is to keep up to date with current CZ release(s), as the Trunk is already.

> warning? Also, what's the deal with locale changes on the 1.8 branch?

(I don't know.)

Comment 3

[Robert Kaiser]

Locale changes on the 1.8 branch are not problem, contrary to the 1.8.0 branch. Only big architecture changes and (big) core/Gecko changes are forbidden on 1.8 branch, new features are allowed (and even wanted).
Only stuff that has been tested well enough on trunk should land on branch though. I got to talk to my SeaMonkey Council fellows, but I think we can give you (the ChatZilla team that is) even a blanket-a+ for landing well-tested, stable ChatZilla updates (like an upgrade to a new known-to-be-good release) at least until the time where we'll cut a 1.1 Alpha release.

Comment 4

[James Ross]

Alright, good. If someone wants to make a patch from branch up to the 0.9.72 release (note: not current trunk), they can.

Comment 5

[Serge Gautherie (:sgautherie)]

(Note: Trunk moved to v0.9.73)

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> Alright, good. If someone wants to make a patch from branch up to the 0.9.72
> release (note: not current trunk), they can.

I could request 1.8 branch approval for the bugs cited in <http://www.hacksrus.com/~ginda/chatzilla/revs.html>, and check that the result is the same as the xpi files available there.
I would make the request rev by rev, from .70 to .73.
(blanket-a+ would be welcomed.)

Would that be appropriate ?

Comment 7

[:Gijs (away/busy until Mar 10)]

It would be rather lame to check in all those bugs one by one in a short timeframe. A diff would be much better.

Comment 8

[James Ross]

If the SeaMonkey Council are willing to blanket a+ landing a complete version (e.g. 0.9.73) I think the only sane thing to do is:
 - Make a diff from current branch to current trunk
 - Let a ChatZilla reviewer run over it quickly to make sure there's nothing
   stupid in there.
 - Land on branch with the blanket a+ in effect.

Do we know what the timescale is for 1.1 Alpha stopping work?

Comment 9

[:Gijs (away/busy until Mar 10)]

Attachment: Patch to trunk

Comment 10

[James Ross]

Comment on attachment 227117 [details] [diff] [review]
Patch to trunk

r=silver

Comment 11

[:Gijs (away/busy until Mar 10)]

Landed -> FIXED

Comment 12

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1a3) Gecko/20060629 SeaMonkey/1.1a] (nightly) (W98SE)

V.Fixed on MOZILLA_1_8_BRANCH.

Comment 13

[Serge Gautherie (:sgautherie)]

|relnote|: The 1.8 branch has CZ v0.9.75.1 currently.