334205 - nsPrimitiveHelpers::ConvertPlatformPlainTextToUnicode returns unitialized value if outUnicodeLen = 0

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[timeless]

it's a rare case, in fact, it's probably virtually impossible. but the code should probably favor initializing rv to NS_OK and i wonder if GetMaxLength can fail :)

Comment 1

[Simon Montagu :smontagu]

Attachment: patch

Comment 2

[Simon Montagu :smontagu]

In fact I don't know how impossible this is: I don't see anything stopping inTextLen from being 0...

Comment 3

[jag (Peter Annema)]

Comment on attachment 218658 [details] [diff] [review]
patch

This seems like the wrong patch. That rv is pretty much directly used in a do_GetService(..., &rv) which will always set it to something.

Comment 4

[Simon Montagu :smontagu]

Attachment: Patch the right place this time

You're right, I patched the wrong place, but do you have any objection to initializing both rvs to NS_OK? It seems like best practice to me.

Comment 5

[Simon Montagu :smontagu]

Attachment: Same, with incorrect comment removed

While I was there, removed a comment that has been inaccurate since rev 1.14. Sorry for the bugspam

Comment 6

[jag (Peter Annema)]

Comment on attachment 218771 [details] [diff] [review]
Same, with incorrect comment removed

I guess I would reorganize the code to make it more clear that rv gets properly initialized, something along the lines of:

  // get the charset
  nsresult rv;
  nsCOMPtr<nsIPlatformCharset> platformCharsetService =
           do_GetService(NS_PLATFORMCHARSET_CONTRACTID, &rv);

  nsCAutoString platformCharset;
  if (NS_SUCCEEDED(rv))
    rv = platformCharsetService->GetCharset(kPlatformCharsetSel_PlainTextInClipboard,
                                            platformCharset);

  if (NS_FAILED(rv))
    platformCharset.AssignLiteral("ISO-8859-1");

Btw, am I missing something, or is |encoder| completely unused?

Comment 7

[Simon Montagu :smontagu]

Attachment: Updated to last comment

Comment 8

[Simon Montagu :smontagu]

Checked in.