334234 - PK11_NewSlotInfo returns freed objects if lock allocations fail

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[timeless]

found by coverity

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Several places we see code that does this in error paths:

 364   	PORT_Free(slot);
 365   	return slot;

Clearly that should be return NULL in each place.

Comment 2

[Alexei Volkov]

Attachment: fix

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 219160 [details] [diff] [review]
fix

r=nelson

Comment 4

[Alexei Volkov]

tip:
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11slot.c,v  <--  pk11slot.c
new revision: 1.88; previous revision: 1.87

3.11 branch:
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11slot.c,v  <--  pk11slot.c
new revision: 1.87.2.1; previous revision: 1.87

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

CID 289

Comment 6

[chris hofmann]

should this fix get picked up on the branch for the next firefox release?

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Chris, What version of NSS is now being used in FF ?

Comment 8

[Daniel Veditz [:dveditz]]

FF2.0.0.1 uses NSS 3.11.4,
FF2.0.0.2 and FF1.5.0.10 use NSS 3.11.5