Closed Bug 334234 Opened 18 years ago Closed 18 years ago

PK11_NewSlotInfo returns freed objects if lock allocations fail

Categories

(NSS :: Libraries, defect, P2)

Product:
NSS
Component:
Libraries
Version:
3.11
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
3.11.1

People

(Reporter: timeless, Assigned: alvolkov.bgs)

References

(
URL
)

Details

(Keywords: coverity, fixed1.8.0.10, fixed1.8.1.1, Whiteboard: CID 289)

Attachments

(1 file)

fix
1.12 KB, patch
nelson
: review+
Details | Diff | Splinter Review 
found by coverity
Assignee: kengert → nobody
Severity: blocker → critical
Priority: -- → P2
Target Milestone: --- → 3.11.1
Version: 4.0 → 3.11
Several places we see code that does this in error paths:

 364   	PORT_Free(slot);
 365   	return slot;

Clearly that should be return NULL in each place.
Assignee: nobody → alexei.volkov.bugs
OS: Linux → All
Hardware: PC → All
Attached patch fix — — Splinter Review 

        Attachment #219160 -
        Flags: review?(nelson)

    
    

    
  
Comment on attachment 219160 [details] [diff] [review]
fix

r=nelson

        Attachment #219160 -
        Flags: review?(nelson) → review+

    
    

    
  
tip:
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11slot.c,v  <--  pk11slot.c
new revision: 1.88; previous revision: 1.87

3.11 branch:
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11slot.c,v  <--  pk11slot.c
new revision: 1.87.2.1; previous revision: 1.87

Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  
CID 289
Whiteboard: CID 289

    
    

    
  
should this fix get picked up on the branch for the next firefox release?
Flags: blocking1.8.1.4?

    
    

    
  
Chris, What version of NSS is now being used in FF ?

    
    

    
  
FF2.0.0.1 uses NSS 3.11.4,
FF2.0.0.2 and FF1.5.0.10 use NSS 3.11.5
Keywords: fixed1.8.0.10, 
          
            fixed1.8.1.1
Flags: blocking1.8.1.4?
Group: security

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: