double free in nsslowkey_ConvertToPublicKey if SECITEM_CopyItem or SECITEM_CopyItem fail

RESOLVED FIXED in 3.11.1

Status

NSS
Libraries
P2
critical
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: timeless, Assigned: Alexei Volkov)

Tracking

({coverity, fixed1.8.0.10, fixed1.8.1.1})

3.11
3.11.1
All
Linux
coverity, fixed1.8.0.10, fixed1.8.1.1

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: CID 500, URL)

Attachments

(1 attachment)

fix
952 bytes, patch
Nelson Bolyard (seldom reads bugmail)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
PORT_FreeArena
nsslowkey_DestroyPublicKey 
nsslowkey_ConvertToPublicKey

PORT_FreeArena
nsslowkey_ConvertToPublicKey

Updated

11 years ago
Assignee: kengert → nobody
Severity: blocker → critical
Priority: -- → P2
Target Milestone: --- → 3.11.1
Version: 4.0 → 3.11
Hardware: PC → All
(Assignee)

Comment 1

11 years ago
Created attachment 219167 [details] [diff] [review]
fix

remove nsslowkey_DestroyPublicKey (pubk) and make arena(and the pubkey) to be freed at the and of the function.
Assignee: nobody → alexei.volkov.bugs
Status: NEW → ASSIGNED
Attachment #219167 - Flags: review?(nelson)
Comment on attachment 219167 [details] [diff] [review]
fix

r=nelson
Attachment #219167 - Flags: review?(nelson) → review+
(Assignee)

Comment 3

11 years ago
tip:
/cvsroot/mozilla/security/nss/lib/softoken/lowkey.c,v  <--  lowkey.c
new revision: 1.7; previous revision: 1.6

3.11 branch:
/cvsroot/mozilla/security/nss/lib/softoken/lowkey.c,v  <--  lowkey.c
new revision: 1.6.30.1; previous revision: 1.6

Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
CID 500
Whiteboard: CID 500

Comment 5

10 years ago
should this fix get picked up for the 2.0.0.4 firefox release?
Flags: blocking1.8.1.4?
Flags: blocking1.8.1.4?
Keywords: fixed1.8.0.10, fixed1.8.1.1
Group: security
You need to log in before you can comment on or make changes to this bug.