334250 - --enable-default-toolkit=cairo-gtk2 not useable since src refers to deprecated cairo symbols

Status: RESOLVED WONTFIX

(Core :: Graphics, defect)

Description

[JF Mertens]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en) AppleWebKit/418 (KHTML, like Gecko) Safari/417.9.2
Build Identifier: seamonkey-1.0.1 (built from src)

here "system-cairo" is the same version as the one in the src.
When building with "--enable-default-toolkit=cairo-gtk2" (rather than just gtk2)
_ and whether or not "--enable-system-cairo" is given _ the build breaks with msgs:
"nsCairoRenderingContext.cpp:99: error: 'cairo_set_target_surface_DEPRECATED_BY_cairo_create' was not declared in this scope"
which indicate refs in the src to symbols from obsolete versions of cairo.

The following command, issue in the builddir, shows the files involved:
/sw/bld/seamonkey-1.0.1-1/mozilla# fgrep -rI "`egrep '_(DEPRECAT|REPLAC)ED' gfx/cairo/cairo/src/cairo.h|sed -r -e 's,.*[[:space:]]+,,' -e 's,_(DEPRECAT|REPLAC).*,,'`" gfx/cairo/cairo/test  gfx/src/cairo|cut -f1 -d:|uniq   
gfx/cairo/cairo/test/cairo_test.c
gfx/cairo/cairo/test/clip_twice.c
gfx/cairo/cairo/test/coverage.c
gfx/cairo/cairo/test/fill_rule.c
gfx/cairo/cairo/test/line_width.c
gfx/cairo/cairo/test/linear_gradient.c
gfx/cairo/cairo/test/move_to_show_surface.c
gfx/cairo/cairo/test/pixman_rotate.c
gfx/cairo/cairo/test/text_cache_crash.c
gfx/cairo/cairo/test/text_rotate.c
gfx/src/cairo/nsCairoBlender.cpp
gfx/src/cairo/nsCairoImage.cpp
gfx/src/cairo/nsCairoRenderingContext.cpp

(rm the "cut -f1 -d:|uniq " to see more)


Reproducible: Always

Steps to Reproduce:
1. Build with "--enable-xft --disable-freetype2 --enable-calendar --enable-optimize="-O3 -fstrict-aliasing" --disable-debug --enable-application=suite --enable-macos-target=10.4 --enable-prebinding --enable-default-toolkit=cairo-gtk2 --with-pthreads --with-default-mozilla-five-home=/sw/lib/seamonkey --mandir=/sw/share/man --enable-strip --enable-extensions=all --enable-image-decoders=all --enable-ldap-experimental --enable-xpctools --enable-necko-protocols=all --enable-efence --enable-ctl --enable-xinerama --with-system-mng --with-system-jpeg --with-system-png --with-system-zlib --enable-postscript --enable-ipv6 --enable-tests --with-x --enable-canvas --with-qtdir=/sw --enable-pango --enable-svg --enable-update-packaging --enable-storage --enable-system-cairo --enable-profilesharing"
2. _
3. _

Actual Results:  
build crashes _ cf supra

Expected Results:  
correct build

With just  --enable-default-toolkit=gtk2  instead of  --enable-default-toolkit=cairo-gtk2
everything is perfect.

Comment 1

[timeless]

you're building an ancient branch. what happens if you build trunk?

Comment 2

[JF Mertens]

Don't want trunk as long as there are no src tarballs. But using lxr, I note that the problem has disappeared in  gfx/src/cairo , and remains in  gfx/cairo/cairo/test .

JF

Comment 3

[Stuart Parmenter]

gfx/src/cairo is gone.  --enable-default-toolkit=cairo-gtk2 is not supported on the branch and almost certainly won't build.

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

gfx/cairo/cairo/test is not built FWIW.