All users were logged out of Bugzilla on October 13th, 2018

handle -P profile in startup script remote sniffing

RESOLVED FIXED

Status

RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: ajschult784, Assigned: ajschult784)

Tracking

Trunk
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

13 years ago
XRemote has the ability to take a -p profile argument, but the startup script doesn't try to do remote sniffing if -P is specified.  I got the other stuff working because handling -P basically means fully parsing the arguments within the script, so it's a bit heavy.  But jag seemed to like the idea.  I'll attach a patch.
(Assignee)

Comment 1

13 years ago
Created attachment 218615 [details] [diff] [review]
patch
Attachment #218615 - Flags: review?(jag)
(Assignee)

Comment 2

13 years ago
Comment on attachment 218615 [details] [diff] [review]
patch

> MOZ_CLIENT_PROGRAM="$dist_bin/mozilla-xremote-client"
> 
> if [ "$OSTYPE" = "beos" ]; then
>   mimeset -F "$MOZ_CLIENT_PROGRAM"
> fi

please assume this is inside the big |if|, between the chunk that parses things (while loop) and the chunk that actually does stuff.

Comment 3

13 years ago
Comment on attachment 218615 [details] [diff] [review]
patch

Please fix the comments around the URL/file: fix-up (move the first bit up to where you grab the (last? assert this?) argument and stuff it in URL, and do s/Last argument/URL/ or something), and as you pointed out yourself, add $profile to the |exec ... openURL|.
Attachment #218615 - Flags: review?(jag) → review-
(Assignee)

Comment 4

13 years ago
what do you mean by "assert"?  print to the console?  not use a remote instance?  bail completely?  comment?
(Assignee)

Comment 5

13 years ago
Created attachment 219493 [details] [diff] [review]
pass arguments to the binary if URL-ish parameter isn't last
Attachment #218615 - Attachment is obsolete: true
Attachment #219493 - Flags: review?(jag)

Updated

13 years ago
Attachment #219493 - Flags: review?(jag) → review+
(Assignee)

Updated

13 years ago
Attachment #219493 - Flags: superreview?(neil)

Updated

13 years ago
Attachment #219493 - Flags: superreview?(neil) → superreview+
(Assignee)

Comment 6

13 years ago
fixed-on-trunk
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(Assignee)

Updated

13 years ago
Attachment #219493 - Flags: approval-branch-1.8.1?(neil)

Comment 7

13 years ago
Comment on attachment 219493 [details] [diff] [review]
pass arguments to the binary if URL-ish parameter isn't last

Assuming you're going to let this bake on the trunk first ;-)
Attachment #219493 - Flags: approval-branch-1.8.1?(neil) → approval-branch-1.8.1+
You need to log in before you can comment on or make changes to this bug.