334288 - use early returns in nsObjectLoadingContent::IsSupportedDocument

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, enhancement)

Description

[timeless]

coverity doesn't like this code, but it's wrong in claiming that it's dangerous.

i don't like this code either, so this bug is a request for:

if (!info)
  return PR_FALSE;

it simplifies the code and happens to quiet coverity (which complains that supported is used uninitialized - in the impossible case of do_GetService setting info to null and rv to ns_ok).

Comment 1

[timeless]

Attachment: use early returns

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 218659 [details] [diff] [review]
use early returns

Single-line ifs should be braced in this code.

Also, I'd like to see both the -w diff and a normal one.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 218659 [details] [diff] [review]
use early returns

what bz said

Comment 4

[John Schoenick [:johns]]

Attachment: Use early returns in nsObjectLoadingContent::IsSupportedDocument

Comment 5

[John Schoenick [:johns]]

Comment on attachment 650304 [details] [diff] [review]
Use early returns in nsObjectLoadingContent::IsSupportedDocument

Resurrecting from the grave!

Comment 6

[John Schoenick [:johns]]

Attachment: Use early returns in nsObjectLoadingContent::IsSupportedDocument

Maybe a version that compiles would be preferable

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 650344 [details] [diff] [review]
Use early returns in nsObjectLoadingContent::IsSupportedDocument

r=me

Comment 8

[John Schoenick [:johns]]

Survived a try push here:
https://tbpl.mozilla.org/?tree=Try&rev=02f602af452c

Landed on m-i:
http://hg.mozilla.org/integration/mozilla-inbound/rev/08631f0a9b1d

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/08631f0a9b1d