334314 - Add missing ECC TLS cipher suites to ssltap

Status: RESOLVED FIXED

(NSS :: Tools, enhancement, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

Now that NSS implements many ECC TLS cipher suites, 
ssltap should recognize them for the 3.11.1 release.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: add ECC cipher suites, v1 (checked in on branch)

Comment 2

[Alexei Volkov]

Comment on attachment 218642 [details] [diff] [review]
add ECC cipher suites, v1 (checked in on branch)

According to draft-ietf-tls-ecc-12.txt the sequence on ciphers suites
should be the following:

     CipherSuite TLS_ECDH_ECDSA_WITH_NULL_SHA           = { 0xC0, 0x00 }
     CipherSuite TLS_ECDH_ECDSA_WITH_RC4_128_SHA        = { 0xC0, 0x01 }
     CipherSuite TLS_ECDH_ECDSA_WITH_DES_CBC_SHA        = { 0xC0, 0x02 }
     CipherSuite TLS_ECDH_ECDSA_WITH_3DES_EDE_CBC_SHA   = { 0xC0, 0x03 }

Unless I've found an outdated document, it should looks like

+  case 0x00C000:    cs_str = "TLS/ECDH-ECDSA/NULL/SHA";         break;
+  case 0x00C001:    cs_str = "TLS/ECDH-ECDSA/RC4-128/SHA";      break;
+  case 0x00C002:    cs_str = "TLS/ECDH-ECDS/DES-CBC/SHA";       break;
+  case 0x00C003:    cs_str = "TLS/ECDH-ECDSA/3DES-EDE-CBC/SHA"; break;

Everything else looks fine.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Alexei, Yes, you've got an outdated document.  
The most current draft, as of this writing, is at http://www.bmoeller.de/internet-drafts/DRAFT3-draft-ietf-tls-ecc-13.txt

Comment 4

[Alexei Volkov]

(In reply to comment #3)
> Alexei, Yes, you've got an outdated document.  
> The most current draft, as of this writing, is at
> http://www.bmoeller.de/internet-drafts/DRAFT3-draft-ietf-tls-ecc-13.txt
> 

Thanks for the link, Nelson. Patch is fine.

Comment 5

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 218642 [details] [diff] [review]
add ECC cipher suites, v1 (checked in on branch)

checked in in NSS 3.11 branch
Checking in ssltap.c; new revision: 1.7.2.1; previous revision: 1.7

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Checked in on trunk and branch.
Checking in ssltap.c; new revision: 1.8;     previous revision: 1.7
Checking in ssltap.c; new revision: 1.7.2.1; previous revision: 1.7