Closed
Bug 334315
Opened 19 years ago
Closed 12 years ago
Change ASSERT/ASSERTION macros to work with coverity
Categories
(Core :: XPCOM, enhancement)
Tracking
()
RESOLVED
INCOMPLETE
People
(Reporter: timeless, Assigned: timeless)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
11.81 KB,
patch
|
brendan
:
superreview-
|
Details | Diff | Splinter Review |
This is a change i'd like to leave in temporarily to see how coverity results change with it applied.
Attachment #218643 -
Flags: superreview?(brendan)
Attachment #218643 -
Flags: review?(wtchang)
Attachment #218643 -
Attachment is obsolete: true
Attachment #218644 -
Flags: superreview?(brendan)
Attachment #218644 -
Flags: review?(wtchang)
Attachment #218643 -
Flags: superreview?(brendan)
Attachment #218643 -
Flags: review?(wtchang)
Summary: Change ASSERT/ASSERION macros to work with coverity → Change ASSERT/ASSERTION macros to work with coverity
|
||
Comment 3•19 years ago
|
||
Comment on attachment 218644 [details] [diff] [review]
treat __COVERITY__ as very DEBUGy for ASSERTs
For the NSPR part of this patch: you should just
compile NSPR with -DFORCE_PR_ASSERT when you use
coverity.
|
||
Comment 4•19 years ago
|
||
Comment on attachment 218644 [details] [diff] [review]
treat __COVERITY__ as very DEBUGy for ASSERTs
I don't like this patch, it's too invasive.
In as few places as possible, define DEBUG if __COVERITY__ is defined.
Don't make up new DEBUG_* macros in nsDebug.h. Rather, just arrange for the right ABORT-ness values at the NS_DEBUG_IMPL_* definition sites.
Minimize!
/be
|
|
||
Updated•19 years ago
|
Attachment #218644 -
Flags: superreview?(brendan) → superreview-
|
||
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•