Change ASSERT/ASSERTION macros to work with coverity

RESOLVED INCOMPLETE

Status

()

Core
XPCOM
--
enhancement
RESOLVED INCOMPLETE
12 years ago
5 years ago

People

(Reporter: timeless, Assigned: timeless)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
This is a change i'd like to leave in temporarily to see how coverity results change with it applied.
(Assignee)

Comment 1

12 years ago
Created attachment 218643 [details] [diff] [review]
treat __COVERITY__ as very DEBUGy for ASSERTs
Attachment #218643 - Flags: superreview?(brendan)
Attachment #218643 - Flags: review?(wtchang)
(Assignee)

Comment 2

12 years ago
Created attachment 218644 [details] [diff] [review]
treat __COVERITY__ as very DEBUGy for ASSERTs
Attachment #218643 - Attachment is obsolete: true
Attachment #218644 - Flags: superreview?(brendan)
Attachment #218644 - Flags: review?(wtchang)
Attachment #218643 - Flags: superreview?(brendan)
Attachment #218643 - Flags: review?(wtchang)
(Assignee)

Updated

12 years ago
Summary: Change ASSERT/ASSERION macros to work with coverity → Change ASSERT/ASSERTION macros to work with coverity

Comment 3

12 years ago
Comment on attachment 218644 [details] [diff] [review]
treat __COVERITY__ as very DEBUGy for ASSERTs

For the NSPR part of this patch: you should just
compile NSPR with -DFORCE_PR_ASSERT when you use
coverity.
Comment on attachment 218644 [details] [diff] [review]
treat __COVERITY__ as very DEBUGy for ASSERTs

I don't like this patch, it's too invasive.

In as few places as possible, define DEBUG if __COVERITY__ is defined.

Don't make up new DEBUG_* macros in nsDebug.h.  Rather, just arrange for the right ABORT-ness values at the NS_DEBUG_IMPL_* definition sites.

Minimize!

/be

Updated

12 years ago
Attachment #218644 - Flags: superreview?(brendan) → superreview-

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.