334327 - pk11_CreateNewContextInSlot: Variable "(context)->key" tracked as NULL was passed to a function that dereferences it.

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[timeless]

found by coverity

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Attachment: Detect NULL symkey

Please review.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Add reviewer to CC list, so he can see the bug!

Comment 3

[Alexei Volkov]

Comment on attachment 218744 [details] [diff] [review]
Detect NULL symkey

Looks ok. 

I also think that PORT_Assert one line before changes should check for the same things.

Another observation is that one of the caller of pk11_CreateNewContextInSlot  -    PK11_CreateContextBySymKey      also dereferences same key without checking it for NULL.

Comment 4

[Nelson Bolyard (seldom reads bugmail)]

(In reply to comment #3)

> Another observation is that one of the caller of pk11_CreateNewContextInSlot  -
>    PK11_CreateContextBySymKey      
> also dereferences same key without checking it for NULL. 

Alexei, please check in the above patch for me, and also write a patch to fix
the problem you discovered in PK11_CreateContextBySymKey.  I'll review it.

Comment 5

[Alexei Volkov]

Check in tip:
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11cxt.c,v  <--  pk11cxt.c
new revision: 1.3; previous revision: 1.2

Check in branch:
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11cxt.c,v  <--  pk11cxt.c
new revision: 1.2.28.1; previous revision: 1.2

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

CID 718

Comment 7

[Nelson Bolyard (seldom reads bugmail)]

Also CID 301.
Related to bug 338071