Closed Bug 334344 Opened 19 years ago Closed 19 years ago

process_bug.cgi is broken when changing several bugs at once

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

2.23
defect
Not set
blocker

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: LpSolit, Assigned: batosti)

References

Details

(Keywords: regression, selenium)

Attachments

(1 file, 1 obsolete file)

This is a regression due to bug 303696. @values is not handled correctly when changing several bugs at once. The bug ID is appended to the existing list of values at each loop, so that the second bug has now the ID "bug1 ID, bug2 ID" instead of "bug2 ID" only.
Attached patch batosti_v1 (obsolete) — Splinter Review
Attachment #218688 - Flags: review?(LpSolit)
Comment on attachment 218688 [details] [diff] [review] batosti_v1 > $query .= " WHERE bug_id = ?"; >- push(@values, $id); > > if ($::comma ne "") { >- $dbh->do($query, undef, @values); >+ $dbh->do($query, undef, @bug_values, $id); No, push $id in @bug_values.
Attachment #218688 - Flags: review?(LpSolit) → review-
Attached patch batosti_v1_fixSplinter Review
Attachment #218688 - Attachment is obsolete: true
Attachment #218690 - Flags: review?(LpSolit)
Comment on attachment 218690 [details] [diff] [review] batosti_v1_fix r=LpSolit
Attachment #218690 - Flags: review?(LpSolit) → review+
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval? → approval+
Checking in process_bug.cgi; /cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v <-- process_bug.cgi new revision: 1.314; previous revision: 1.313 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Flags: testcase?
Flags: testcase? → testcase+
Keywords: selenium
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: