nsslowcert_UpdateSubjectEmailAddr doesn't consistently use emailAddrs as a guard of nemailAddrs guarding emailAddrs[0]

RESOLVED FIXED in 3.11.1

Status

NSS
Libraries
P3
trivial
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: timeless, Assigned: Alexei Volkov)

Tracking

({coverity, crash})

3.11
3.11.1
All
Linux
coverity, crash

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: CID 227, URL)

Attachments

(1 attachment)

1.00 KB, patch
Nelson Bolyard (seldom reads bugmail)
: review+
Details | Diff | Splinter Review
(Reporter)

Description

12 years ago
found by coverity
(Reporter)

Comment 1

12 years ago
Created attachment 218779 [details] [diff] [review]
remove hopefully unnecessary null check

i'm guessing there's an assertion to be had here and that the null check can be removed.
Attachment #218779 - Flags: review?
(Reporter)

Updated

12 years ago
Attachment #218779 - Flags: review? → review?(nelson)
Target Milestone: --- → 3.11.1
Priority: -- → P2
Hardware: PC → All
Comment on attachment 218779 [details] [diff] [review]
remove hopefully unnecessary null check

Yes, it appears that this null check is unnecessary.
I see nothing critical about an extra null pointer check.
Attachment #218779 - Flags: review?(nelson) → review+
Alexei, please check in.
Assignee: nobody → alexei.volkov.bugs
Severity: critical → trivial
Priority: P2 → P3
(Assignee)

Comment 4

12 years ago
tip:
/cvsroot/mozilla/security/nss/lib/softoken/pcertdb.c,v  <--  pcertdb.c
new revision: 1.60; previous revision: 1.59

3.11 branch:
/cvsroot/mozilla/security/nss/lib/softoken/pcertdb.c,v  <--  pcertdb.c
new revision: 1.53.2.6; previous revision: 1.53.2.5

Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
CID 227
Whiteboard: CID 227
You need to log in before you can comment on or make changes to this bug.