Closed
Bug 334443
Opened 19 years ago
Closed 19 years ago
oom Crash in nssCKFWSession_Create
Categories
(NSS :: Libraries, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
3.11.1
People
(Reporter: timeless, Assigned: alvolkov.bgs)
References
()
Details
(Keywords: coverity, crash, Whiteboard: CID 215)
Attachments
(1 file)
|
2.71 KB,
patch
|
nelson
:
review+
|
Details | Diff | Splinter Review |
found by coverity
Attachment #218786 -
Flags: review?(nelson)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 218786 [details] [diff] [review]
look before leaping
r=nelson with suggested improvement.
> loser:
> if( (NSSArena *)NULL != arena ) {
>- if( (nssCKFWHash *)NULL != fwSession->sessionObjectHash ) {
>+ if( fwSession && (nssCKFWHash *)NULL != fwSession->sessionObjectHash ) {
even better:
if( fwSession && fwSession->sessionObjectHash ) {
> (void)nssCKFWHash_Destroy(fwSession->sessionObjectHash);
> }
> NSSArena_Destroy(arena);
> }
Attachment #218786 -
Flags: review?(nelson) → review+
|
|
||
Updated•19 years ago
|
Target Milestone: --- → 3.11.1
|
|
||
Updated•19 years ago
|
Priority: -- → P2
Hardware: PC → All
|
Assignee | |
Comment 3•19 years ago
|
||
tip:
/cvsroot/mozilla/security/nss/lib/ckfw/session.c,v <-- session.c
new revision: 1.10; previous revision: 1.9
3.11 branch:
/cvsroot/mozilla/security/nss/lib/ckfw/session.c,v <-- session.c
new revision: 1.8.28.1; previous revision: 1.8
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•19 years ago
|
Assignee: nobody → alexei.volkov.bugs
You need to log in
before you can comment on or make changes to this bug.
Description
•