334458 - Variable "(cache)->sharedCache" tracked as NULL was passed to a function that dereferences it. [@ CloseCache - InitCache]

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P2)

Description

[timeless]

found by coverity

Comment 1

[Alexei Volkov]

Does not look like a bug to me. 

sharedCache and cacheMem both get assigned to NULL/0 in the beginning of InitCache function. 
939     cache->shared = shared;
940     cache->cacheMem    = cacheMem    = NULL;
941     cache->cacheMemMap = cacheMemMap = NULL;
942     cache->sharedCache = (cacheDesc *)0;

Later in the same function, both variable get set to cacheMem, but only after cacheMem allocation is successful.

1071     cache->cacheMem    = cacheMem;
1072     cache->sharedCache = (cacheDesc *)cacheMem;

Therefore it is sufficient to verify that cacheMem is not NULL to proceed with 
dereferencing of sharedCache in function CloseCash. 

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

In this function, there are some lines of code that look like this:
     cfn = PR_smprintf( ...

PR_smprintf allocates the memory it returns. 
If it fails to allocate that memory (out of memory), 
then the code below it goes to loser 
with (cache)->sharedCache still NULL.

Comment 3

[Alexei Volkov]

Coverity CID 203

Comment 4

[Julien Pierre]

Retargetting all P2s to 3.11.3 .

Comment 5

[Alexei Volkov]

Attachment: fix

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 226831 [details] [diff] [review]
fix

r=nelson

Comment 7

[Alexei Volkov]

tip:
new revision: 1.38; previous revision: 1.37

3.11 branch:
new revision: 1.36.2.2; previous revision: 1.36.2.1

Comment 8

[Alexei Volkov]

tip:
new revision: 1.38; previous revision: 1.37

3.11 branch:
new revision: 1.36.2.2; previous revision: 1.36.2.1