334460 - turn warning on re-entry into frame construction into an assertion

Status: RESOLVED FIXED

(Core :: Layout, defect, P4)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In bug 310985, I added a bunch of assertions about re-entry into layout that breaks invariants.  However, the one about re-entry into frame construction had to be a warning rather than an assertion because we hit it too often (or maybe not?).  This bug is on turning it back into an assertion.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Dropping from the 1.9 blocking list at this point.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I believe we can flip this now.  Anyone object?

Comment 3

[Timothy Nikkel (:tnikkel)]

Shall we flip it then?

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Sounds good to me.

Comment 5

[Timothy Nikkel (:tnikkel)]

Attachment: patch

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 402265 [details] [diff] [review]
patch

Let's do it.  Looking forward to Jesse finding any remaining edge cases!

Comment 7

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/mozilla-central/rev/eb4e7e25a988

Comment 8

[Timothy Nikkel (:tnikkel)]

Jesse and Martijn, we turned a warning that you are probably used to seeing into an assertion that we want reported now because we hope that we got rid of all the false positives.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

We'll take this on branch if the assertions don't fire there.

Comment 10

[Timothy Nikkel (:tnikkel)]

Comment on attachment 402265 [details] [diff] [review]
patch

They shouldn't be firing on 1.9.2.

Comment 11

[Timothy Nikkel (:tnikkel)]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/805c23bcbeb5