The default bug view has changed. See this FAQ.

[branch only] deadlock in nsObserverList::RemoveObserver

RESOLVED FIXED in mozilla1.8.1

Status

()

Core
XPCOM
--
critical
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Darin Fisher, Assigned: Darin Fisher)

Tracking

({fixed1.8.0.4, fixed1.8.1})

Trunk
mozilla1.8.1
fixed1.8.0.4, fixed1.8.1
Points:
---
Bug Flags:
blocking1.8.1 +
blocking1.8.0.4 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

11 years ago
Possible deadlock in nsObserverList::RemoveObserver

If RemoveObserver results in an observer being destroyed, then that could result in another call to RemoveObserver, which will dead-lock trying to acquire nsObserverList::mLock.  This is not a bug on the trunk because mLock has been removed.

The simple solution is to insert a kungFuDeathGrip.
(Assignee)

Comment 1

11 years ago
Created attachment 218885 [details] [diff] [review]
v1 patch
Attachment #218885 - Flags: review?(benjamin)
(Assignee)

Comment 2

11 years ago
Created attachment 218886 [details]
stack showing deadlock
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
Flags: blocking1.8.1?
Flags: blocking1.8.0.3?
Summary: [branch only] possible deadlock in nsObserverList::RemoveObserver → [branch only] deadlock in nsObserverList::RemoveObserver
Target Milestone: --- → mozilla1.8.1
Attachment #218885 - Flags: review?(benjamin) → review+
(Assignee)

Comment 3

11 years ago
Comment on attachment 218885 [details] [diff] [review]
v1 patch

Actually, I meant to request 1.8.1 approval too.  This is 1.8 branch only.
Attachment #218885 - Flags: approval1.8.0.3?
Attachment #218885 - Flags: approval-branch-1.8.1?(benjamin)
Comment on attachment 218885 [details] [diff] [review]
v1 patch

Yeah, me too ;-)
Attachment #218885 - Flags: approval-branch-1.8.1?(benjamin) → approval-branch-1.8.1+
(Assignee)

Comment 5

11 years ago
fixed1.8.1
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Flags: blocking1.8.1?
Flags: blocking1.8.1+
Flags: blocking1.8.0.3?
Flags: blocking1.8.0.3+
Comment on attachment 218885 [details] [diff] [review]
v1 patch

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #218885 - Flags: approval1.8.0.3? → approval1.8.0.3+
(Assignee)

Comment 7

11 years ago
fixed1.8.0.4
Keywords: fixed1.8.0.4
please provide guidance on how to verify this fix on the 180 branch
You need to log in before you can comment on or make changes to this bug.