334537 - nsMenuBarX.mm installs an event handler poorly

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Mark Mentovai]

I didn't think this was worth its own bug, but I can't find Josh right now.

In nsMenuBarX.mm, nsMenuBarX::InstallCommandEventHandler():

     const EventTypeSpec commandEventList[] = {{kEventClassCommand, kEventComma
ndProcess}};
     err = ::InstallWindowEventHandler(myWindowRef, sCommandEventHandler, 2, co
mmandEventList, this, NULL);

There's only one event type in the list, so the third argument to InstallWindowEventHandler should be 1.  Better yet, it should be GetEventTypeCount.

Also included in the patch: elimination of an unnecessary switch.

Comment 1

[Mark Mentovai]

Attachment: Fix

Comment 2

[Mark Mentovai]

Landed on the trunk.