334561 - Clean up spec file for RPM build

Status: RESOLVED FIXED

(Directory Graveyard :: LDAP C SDK, defect)

Description

[Rich Megginson]

There are a number of things that need to be done to the RPM spec file in preparation for the inclusion of svrcore and the ldap sdk into Fedora Core and RHEL.

Comment 1

[Rich Megginson]

Attachment: list of files in mozldap and svrcore

List of files affected

Comment 2

[Rich Megginson]

Attachment: diffs for fix

Parameterize the names of packages used wherever possible, to make it easier to change the names of things in the future.
Change the package name of svrcore to svrcore-devel in some places - this mostly affects usage with pkg-config
Fixed a bug with shared library symlink creation - was using ${major} instead of %{major}
Move all Requires and BuildRequires to one item per line
Get rid of dependencies on pkgconfig and gawk

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

One thing thats worth keeping in mind is that the client C SDK branch doesnt itself control which NSPR and NSS it will be built with.  When building Thunderbird from the trunk, we may well get different versions of that stuff than when building from the MOZILLA_1_8_BRANCH (that stuff is decided in client.mk).  This may be relevant for the spec file changes. 

In general, this looks more than reasonable, and I have no objection to it landing on the client branch once it has been reviewed.

Comment 4

[Rich Megginson]

I'll be working with Chris Aillon on any mozilla client build changes to use system nspr, nss, and system mozldap.  If the mozilla client build wants to use the mozldap in the OS it will have to change.  If the mozilla client build wants to tell mozldap to use the nspr and nss in the OS, it can use --with-system-nspr and --with-system-nss.  This only applies to RHEL/Fedora Core right now since those are the only OSes targeted to have mozldap in the OS.  But I suspect it may be a moot point if we have to build static versions of mozldap and link them into the mozilla client in order to get around the openldap problem https://bugzilla.mozilla.org/show_bug.cgi?id=292127

Comment 5

[Rich Megginson]

Attachment: files for fix

Comment 6

[Rich Megginson]

Attachment: diffs for fix

Comment 7

[Rich Megginson]

Can I get a review?

Comment 8

[Mark Smith [:mcs]]

Comment on attachment 220706 [details]
diffs for fix

Looks OK to me (I don't know a lot about spec files though).

Comment 9

[Mark Smith [:mcs]]

-> Rich.

Comment 10

[Rich Megginson]

Fixed:
Checking in directory/c-sdk/mozldap.spec;
/cvsroot/mozilla/directory/c-sdk/mozldap.spec,v  <--  mozldap.spec
new revision: 5.5; previous revision: 5.4
done
RCS file: /cvsroot/mozilla/security/svrcore/build_svrcore-devel_rpm,v
done
Checking in security/svrcore/build_svrcore-devel_rpm;
/cvsroot/mozilla/security/svrcore/build_svrcore-devel_rpm,v  <--  build_svrcore-devel_rpm
initial revision: 1.1
done
Checking in security/svrcore/svrcore.spec;
/cvsroot/mozilla/security/svrcore/svrcore.spec,v  <--  svrcore.spec
new revision: 1.4; previous revision: 1.3
done