334586 - Hook FAYT highlight color up to system prefs

Status: NEW

(Core :: Widget: Cocoa, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

FAYT currently uses the default FAYT highlight color while Find uses the user's system highlight color.

We should hook the FAYT highlight color pref into whatever we use to grab the highlight color from the System Prefs.

user_pref("ui.textSelectBackgroundAttention", "#rrggbb"); // where rrggbb is the hex color you want for found text.

Comment 1

[Chris Lawson (gone)]

This only happens when FAYT is not timed-out (is "active", in other words). There is, however, a bug in the timeout, at least on my system, which I think I reported.

cl

Comment 2

[Chris Lawson (gone)]

Taking so that I can look into this for 1.6.

Comment 3

[Chris Lawson (gone)]

I totally forgot about this.

http://www.cocoadev.com/index.pl?NSColor

may be useful, along with |selectedTextBackgroundColor|.

We may want to set up a listener for the change notification too, unless we'd prefer to ignore that pref entirely (although I'm not sure how difficult that would be; i.e., how deep into Core code that colour is) and just use the system highlight colour to begin with.

Comment 4

[Chris Lawson (gone)]

Hrm. Instead of using a pref, is there any reason why Mac widget code doesn't just pull the system highlight colour already (in /widget/src/cocoa/nsLookAndFeel.* )?

Josh, should we just kick this to Core?

Comment 5

[Chris Lawson (gone)]

I'm gonna kick this to widget to keep it on Josh's radar.