334609 - On initial paint, caret sometimes paints too short

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Blake Kaplan (:mrbkap) (inactive)]

<I don't have a reduced testcase for this yet>

I've noticed during some testcases that the caret will only paint half as "tall" as the input box that it's in. It seems to always erase the correct rect and correct itself on the second blink, however (by "tall", I mean that the caret will stretch from the top of the input box to only a few pixels down instead of all the way to the bottom).

Note: I seem to be able to trigger this behavior (on Windows, at least, though I think I've seen it while debugging on Linux) by opening the find toolbar with either ctrl+f or using type-ahead-find's '/'.

Comment 1

[Tuukka Tolvanen (sp3000)]

I see this with toolkit=gtk2 in the find bar. ->all

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

What was happening here is that the caret was being told to blink in a frame that hadn't been reflowed yet (or had reflowed too short initially). Then when we did reflow the frame, the caret already had a size and position. This patch fixes this bug by making sure the caret updates its position before painting after a reflow.

I also changed the order of the InvalidateOutsideCaret and UpdateCaretPosition calls to favor invalidating the old position (which seems safer to me).

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Fix checked into trunk.