Closed Bug 334655 Opened 14 years ago Closed 14 years ago

probably uninitialized rv in DocumentViewerImpl::LoadStart

Categories

(Core :: Layout, defect)

x86
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: guninski, Assigned: dbaron)

References

(Blocks 1 open bug, )

Details

(Keywords: coverity, fixed1.8.1)

Attachments

(1 file)

570 DocumentViewerImpl::LoadStart(nsISupports *aDoc)
571 {
572 #ifdef NOISY_VIEWER
573   printf("DocumentViewerImpl::LoadStart\n");
574 #endif
575 
576   nsresult rv;
^^^^^^^^^^^^^^^^^^^
577   if (!mDocument) {
578     mDocument = do_QueryInterface(aDoc, &rv);
579   }
580   else if (mDocument == aDoc) {
^^^^^^^^^^^^^^^^^^^
581     // Reset the document viewer's state back to what it was
582     // when the document load started.
583     PrepareToStartLoad();
584   }
585 
586   return rv;
^^^^^^^^^^^^
587 }

CID 459
potential fix may be:
576   nsresult rv=NS_OK;
OR
583     PrepareToStartLoad();
+ rv=NS_OK
Attached patch patchSplinter Review
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Attachment #219032 - Flags: superreview?(roc)
Attachment #219032 - Flags: review?(roc)
Attachment #219032 - Flags: approval-branch-1.8.1?(roc)
This is probably propagated only to things that don't check the return value (or otherwise valgrind would have told us).  But still worth fixing.
Component: General → Layout: Misc Code
Flags: review?(roc)
Product: Firefox → Core
QA Contact: general → layout.misc-code
Attachment #219032 - Flags: superreview?(roc)
Attachment #219032 - Flags: superreview+
Attachment #219032 - Flags: review?(roc)
Attachment #219032 - Flags: review+
Attachment #219032 - Flags: approval-branch-1.8.1?(roc)
Attachment #219032 - Flags: approval-branch-1.8.1+
Checked in to trunk and MOZILLA_1_8_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Group: security
Product: Core → Core Graveyard
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in before you can comment on or make changes to this bug.