334655 - probably uninitialized rv in DocumentViewerImpl::LoadStart

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[georgi - hopefully not receiving bugspam]

570 DocumentViewerImpl::LoadStart(nsISupports *aDoc)
571 {
572 #ifdef NOISY_VIEWER
573   printf("DocumentViewerImpl::LoadStart\n");
574 #endif
575 
576   nsresult rv;
^^^^^^^^^^^^^^^^^^^
577   if (!mDocument) {
578     mDocument = do_QueryInterface(aDoc, &rv);
579   }
580   else if (mDocument == aDoc) {
^^^^^^^^^^^^^^^^^^^
581     // Reset the document viewer's state back to what it was
582     // when the document load started.
583     PrepareToStartLoad();
584   }
585 
586   return rv;
^^^^^^^^^^^^
587 }

CID 459

Comment 1

[georgi - hopefully not receiving bugspam]

potential fix may be:
576   nsresult rv=NS_OK;
OR
583     PrepareToStartLoad();
+ rv=NS_OK

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is probably propagated only to things that don't check the return value (or otherwise valgrind would have told us).  But still worth fixing.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk and MOZILLA_1_8_BRANCH.