334678 - prng_fips1861.c redefines the macro BSIZE on HP-UX

Status: VERIFIED FIXED

(NSS :: Libraries, defect)

Description

[Wan-Teh Chang]

When we compile NSS on HP-UX, we get the following compiler warning:

cc -o HP-UXB.11.11_DBG.OBJ/HP-UX_ABI32_FPU/prng_fips1861.o -c -g -DHPUX10 -Ae +Z
 -DHPUX -Dhppa -D_HPUX_SOURCE -D_USE_BIG_FDS -Aa +e +DA2.0 +DS2.0 -DHPUX11 -DXP_
UNIX -DSHLIB_SUFFIX=\"sl\" -DSHLIB_PREFIX=\"lib\" -DSHLIB_VERSION=\"_3\" -DSOFTO
KEN_SHLIB_VERSION=\"3\" -DRIJNDAEL_INCLUDE_TABLES -DDEBUG -UNDEBUG -DDEBUG_svrbl
d -DNSS_USE_ABI32_FPU -DMP_ASSEMBLY_MULTIPLY -DMP_ASSEMBLY_SQUARE -DMP_API_COMPA
TIBLE -I../../../../dist/HP-UXB.11.11_DBG.OBJ/include  -I../../../../dist/public
/nss -I../../../../dist/private/nss -Impi -Iecl  prng_fips1861.c
cpp: "prng_fips1861.c", line 78: warning 2001: Redefinition of macro BSIZE.

I examined all the system headers in /usr/include and its subdirectories.
I found that the macro BSIZE is defined in the system header file
<sys/param.h>:

#define BSIZE   DEV_BSIZE

but not used anywhere.  So the redefinition of macro BSIZE in prng_fips1861.c
is benign, hence the "trivial" severity of this bug.

I suggest that we only fix this bug (by renaming BSIZE as RNG_BSIZE
or FIPS_BSIZE, and renaming the related macro GSIZE similarly) on the
trunk (NSS 3.12) to avoid redoing the FIPS RNG algorithm testing.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

I suggest you merely 
#undef BSIZE

Comment 2

[glen beasley]

bug 457045 has fixed this issue by replacing FIPS 186-2 PRNG with SP 800-90 Hash_DRBG. The file prng_fips1861.c no longer exists in the current NSS source.