334679 - Duplicate line in ec_GF2m_validate_point

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Wan-Teh Chang]

I found this bug by code inspection.  In
lib/freebl/ecl/ec2_aff.c:ec_GF2m_validate_point, there
is a duplicate line:

    /* left-hand side: y^2 + x*y  */
    MP_CHECKOK( group->meth->field_sqr(&pyt, &accl, group->meth) );
    MP_CHECKOK( group->meth->field_mul(&pxt, &pyt, &tmp, group->meth) );
    MP_CHECKOK( group->meth->field_mul(&pxt, &pyt, &tmp, group->meth) );
    MP_CHECKOK( group->meth->field_add(&accl, &tmp, &accl, group->meth) );

The duplicate line is harmless because it simply does
the same operation again (in pseudo-code):

    tmp = pxt * pyt;
    tmp = pxt * pyt;

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch

Remove the duplicate line.

Comment 2

[Wan-Teh Chang]

I checked in the patch on the NSS trunk (3.12) and the
NSS_3_11_BRANCH (3.11.2).

Checking in ec2_aff.c;
/cvsroot/mozilla/security/nss/lib/freebl/ecl/ec2_aff.c,v  <--  ec2_aff.c
new revision: 1.4; previous revision: 1.3
done

Checking in ec2_aff.c;
/cvsroot/mozilla/security/nss/lib/freebl/ecl/ec2_aff.c,v  <--  ec2_aff.c
new revision: 1.3.2.1; previous revision: 1.3
done