334718 - Ineffective allocation check in NS_NewSVGCairoPathBuilder (nsSVGCairoPathBuilder.cpp)

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Kenneth Herron]

This was found through a coverity scan of the mozilla source. |NS_NewSVGCairoPathBuilder| in nsSVGCairoPathBuilder.cpp contains the following code:

 86 nsresult
 87 NS_NewSVGCairoPathBuilder(nsISVGRendererPathBuilder **result,
 88                           cairo_t *ctx)
 89 {
 90   *result = new nsSVGCairoPathBuilder(ctx);
 91   if (!result)
 92     return NS_ERROR_OUT_OF_MEMORY;
 93 
 94   NS_ADDREF(*result);

Shirley line 91 should be testing |*result|, not |result|.

Comment 1

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Fix null check on *result

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 219219 [details] [diff] [review]
Fix null check on *result

r=jwatt

Comment 3

[tor]

Comment on attachment 219219 [details] [diff] [review]
Fix null check on *result

File no longer exists on trunk, but could be taken for the 1.8.* branches.

Comment 4

[Darin Fisher]

Comment on attachment 219219 [details] [diff] [review]
Fix null check on *result

a=darin on behalf of drivers

Comment 5

[:Gavin Sharp [email: [e-mail]]]

mozilla/layout/svg/renderer/src/cairo/Attic/nsSVGCairoPathBuilder.cpp 1.6.6.1

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 219219 [details] [diff] [review]
Fix null check on *result

approved for 1.8.0 branch, a=dveditz for drivers

Comment 7

[Daniel Veditz [:dveditz]]

Fix checked into 1.8.0 branch