Closed Bug 334870 Opened 16 years ago Closed 16 years ago

nsIPluginHost.h fails to compile without MOZILLA_INTERNAL_API defined

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bryner, Assigned: bryner)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

nsIPluginHost.idl includes some internal headers that it needs for NS_NewPluginPostDataStream().  This brings in the internal string classes, which is bad for using this interface with the frozen XPCOM API.  Quick and dirty fix is to ifdef the includes and inline function; better fix going forward is to factor them out into a new header.
Attached patch patchSplinter Review
Attachment #219201 - Flags: review?(darin)
Attachment #219201 - Flags: approval-branch-1.8.1?(darin)
Attachment #219201 - Flags: review?(darin)
Attachment #219201 - Flags: review+
Attachment #219201 - Flags: approval-branch-1.8.1?(darin)
Attachment #219201 - Flags: approval-branch-1.8.1+
checked in
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
can you file a new bug on moving this to a different header?
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.