Closed
Bug 334870
Opened 19 years ago
Closed 19 years ago
nsIPluginHost.h fails to compile without MOZILLA_INTERNAL_API defined
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bryner, Assigned: bryner)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
952 bytes,
patch
|
darin.moz
:
review+
darin.moz
:
approval-branch-1.8.1+
|
Details | Diff | Splinter Review |
nsIPluginHost.idl includes some internal headers that it needs for NS_NewPluginPostDataStream(). This brings in the internal string classes, which is bad for using this interface with the frozen XPCOM API. Quick and dirty fix is to ifdef the includes and inline function; better fix going forward is to factor them out into a new header.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #219201 -
Flags: review?(darin)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #219201 -
Flags: approval-branch-1.8.1?(darin)
|
||
Updated•19 years ago
|
Attachment #219201 -
Flags: review?(darin)
Attachment #219201 -
Flags: review+
Attachment #219201 -
Flags: approval-branch-1.8.1?(darin)
Attachment #219201 -
Flags: approval-branch-1.8.1+
|
|
Assignee | |
Comment 2•19 years ago
|
||
checked in
|
||
Comment 3•19 years ago
|
||
can you file a new bug on moving this to a different header?
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•