Closed Bug 334897 Opened 18 years ago Closed 18 years ago

Useless null check of shell in nsFrame::Destroy

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

(Blocks 1 open bug,
URL
)

Details

(Keywords: coverity)

Attachments

(1 obsolete file) 

i hope this is a useless null check, if it isn't, we crash at the end of this function.
Keywords: coverity
Yeah, looks useless.
Attached patch remove useless null check (obsolete) — — Splinter Review 
Assignee: nobody → timeless
Status: NEW → ASSIGNED

        Attachment #219266 -
        Flags: superreview?(dbaron)

        Attachment #219266 -
        Flags: review?(dbaron)

        Attachment #219266 -
        Flags: superreview?(dbaron)

        Attachment #219266 -
        Flags: superreview+

        Attachment #219266 -
        Flags: review?(dbaron)

        Attachment #219266 -
        Flags: review+

    
    

    
  
Comment on attachment 219266 [details] [diff] [review]
remove useless null check

mozilla/layout/generic/nsFrame.cpp 	3.646

        Attachment #219266 -
        Attachment is obsolete: true

    
  
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: