334903 - Seamonkey update page appears in window with no navigation or tabs

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Aaron Lawrence]

If you click Yes to update, when the "update available" appears, then you get a new window with no navigation (back, forward, URL etc) and no tabs bar. This makes it quite difficult to use. 
Expected: a normal browser window; actually, a normal browser tab, because I have it set to open new windows in tabs.

Seamonkey 1.0. Have installed 1.0.1 but can't recheck on demand - there's no way to do that, is there?

Comment 1

[Andrew Schultz]

http://lxr.mozilla.org/seamonkey/source/xpfe/components/updates/src/nsUpdateNotifier.js#266

I can't get update to kick in, but IIRC, windowWatcher uses its psychic powers to determine that we want a dialog because the last argument passed in is null (rather than an empty string).

Comment 2

[RickieES aka Ricardo Palomares]

(In reply to comment #0)
> 
> Seamonkey 1.0. Have installed 1.0.1 but can't recheck on demand - there's no
> way to do that, is there?
> 


If you enter in about:config, reset the preference:

update_notifications.provider.0.last_checked

to 0, restart SeaMonkey and browse the web for a while, it shouldn't pass too much time before you get the update notification.

BTW, I can confirm this behaviour in Windows (XP), and I can confirm that this doesn't happen in Linux (using IceWM).

Comment 3

[RickieES aka Ricardo Palomares]

I forgot to say that Bug 334339 is a dup of this one (or this one is a dup of 334339).

Comment 4

[Andrew Schultz]

Attachment: patch

Let's not pretend a webpage is chrome!

Comment 5

[Andrew Schultz]

*** Bug 334339 has been marked as a duplicate of this bug. ***

Comment 6

[[e-mail]]

Comment on attachment 228020 [details] [diff] [review]
patch

>+        var argstring = Components.classes["@mozilla.org/supports-string;1"].
>+           createInstance(Components.interfaces.nsISupportsString);
Nit: bogus 3-space indent, and . should be at the start of the second line.

Comment 7

[Andrew Schultz]

Comment on attachment 228020 [details] [diff] [review]
patch

This is on trunk, but won't actually be tested (by the masses) until it's in 1.0.x

Comment 8

[Robert Kaiser]

Comment on attachment 228020 [details] [diff] [review]
patch

a=me for 1.1, first-a=me for 1.0.x, still one needed to go

Comment 9

[Chris Thomas (CTho) [formerly [e-mail] [e-mail]]]

Comment on attachment 228020 [details] [diff] [review]
patch

a=me for 1.0.3

Comment 10

[Andrew Schultz]

landed on both branches