Closed
Bug 334914
Opened 20 years ago
Closed 20 years ago
hopefully useless null check of out it in JAR_find_next
Categories
(NSS :: Tools, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
3.12
People
(Reporter: timeless, Unassigned)
References
()
Details
(Keywords: coverity)
Attachments
(1 file, 1 obsolete file)
|
756 bytes,
patch
|
wtc
:
review+
|
Details | Diff | Splinter Review |
everyone else assumes that it can't possibly null.
|
||
Updated•20 years ago
|
Priority: -- → P3
|
|
||
Updated•20 years ago
|
Hardware: PC → All
Target Milestone: --- → 3.11.2
|
|
||
Updated•20 years ago
|
Component: Libraries → Tools
QA Contact: libraries → tools
|
||
Comment 2•20 years ago
|
||
Patch v1 - remove the null checks.
Attachment #239668 -
Flags: superreview?(wtchang)
Attachment #239668 -
Flags: review?
|
||
Comment 3•20 years ago
|
||
Comment on attachment 239668 [details] [diff] [review]
Patch v1
Thanks for the patch. We need to keep the !*it test.
Only the !it test can be removed.
Attachment #239668 -
Flags: superreview?(wtchang)
Attachment #239668 -
Flags: superreview-
Attachment #239668 -
Flags: review?
|
|
||
Comment 4•20 years ago
|
||
Whoops... my bad - should have looked what I was deleting there.
Attachment #239668 -
Attachment is obsolete: true
Attachment #239684 -
Flags: superreview?(wtchang)
Attachment #239684 -
Flags: review?(wtchang)
|
|
||
Updated•20 years ago
|
Attachment #239684 -
Flags: superreview?(wtchang)
Attachment #239684 -
Flags: review?(wtchang)
Attachment #239684 -
Flags: review+
|
|
||
Comment 5•20 years ago
|
||
I checked in the fix on the NSS trunk (NSS 3.12). Thanks
for the patch.
Checking in jar.c;
/cvsroot/mozilla/security/nss/lib/jar/jar.c,v <-- jar.c
new revision: 1.4; previous revision: 1.3
done
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: 3.11.3 → 3.12
You need to log in
before you can comment on or make changes to this bug.
Description
•