hopefully useless null check of out it in JAR_find_next

RESOLVED FIXED in 3.12

Status

NSS
Tools
P3
trivial
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: timeless, Unassigned)

Tracking

({coverity})

3.11
3.12
All
Linux
coverity

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

756 bytes, patch
Wan-Teh Chang
: review+
Details | Diff | Splinter Review
(Reporter)

Description

12 years ago
everyone else assumes that it can't possibly null.
Priority: -- → P3
Hardware: PC → All
Target Milestone: --- → 3.11.2

Comment 1

11 years ago
Retargetting all P2s to 3.11.3 .
Target Milestone: 3.11.2 → 3.11.3
Component: Libraries → Tools
QA Contact: libraries → tools
Created attachment 239668 [details] [diff] [review]
Patch v1

Patch v1 - remove the null checks.
Attachment #239668 - Flags: superreview?(wtchang)
Attachment #239668 - Flags: review?

Comment 3

11 years ago
Comment on attachment 239668 [details] [diff] [review]
Patch v1

Thanks for the patch.  We need to keep the !*it test.
Only the !it test can be removed.
Attachment #239668 - Flags: superreview?(wtchang)
Attachment #239668 - Flags: superreview-
Attachment #239668 - Flags: review?
Created attachment 239684 [details] [diff] [review]
Patch v2

Whoops... my bad - should have looked what I was deleting there.
Attachment #239668 - Attachment is obsolete: true
Attachment #239684 - Flags: superreview?(wtchang)
Attachment #239684 - Flags: review?(wtchang)

Updated

11 years ago
Attachment #239684 - Flags: superreview?(wtchang)
Attachment #239684 - Flags: review?(wtchang)
Attachment #239684 - Flags: review+

Comment 5

11 years ago
I checked in the fix on the NSS trunk (NSS 3.12).  Thanks
for the patch.

Checking in jar.c;
/cvsroot/mozilla/security/nss/lib/jar/jar.c,v  <--  jar.c
new revision: 1.4; previous revision: 1.3
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
Target Milestone: 3.11.3 → 3.12
You need to log in before you can comment on or make changes to this bug.