Last Comment Bug 334914 - hopefully useless null check of out it in JAR_find_next
: hopefully useless null check of out it in JAR_find_next
Status: RESOLVED FIXED
: coverity
Product: NSS
Classification: Components
Component: Tools (show other bugs)
: 3.11
: All Linux
: P3 trivial (vote)
: 3.12
Assigned To: nobody
:
:
Mentors:
http://bonsai.mozilla.org/cvsblame.cg...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-04-20 23:19 PDT by timeless
Modified: 2006-09-22 12:03 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch v1 (748 bytes, patch)
2006-09-22 09:48 PDT, Ryan Jones
wtc: superreview-
Details | Diff | Splinter Review
Patch v2 (756 bytes, patch)
2006-09-22 11:47 PDT, Ryan Jones
wtc: review+
Details | Diff | Splinter Review

Description timeless 2006-04-20 23:19:34 PDT
everyone else assumes that it can't possibly null.
Comment 1 Julien Pierre 2006-06-20 16:31:56 PDT
Retargetting all P2s to 3.11.3 .
Comment 2 Ryan Jones 2006-09-22 09:48:16 PDT
Created attachment 239668 [details] [diff] [review]
Patch v1

Patch v1 - remove the null checks.
Comment 3 Wan-Teh Chang 2006-09-22 11:41:24 PDT
Comment on attachment 239668 [details] [diff] [review]
Patch v1

Thanks for the patch.  We need to keep the !*it test.
Only the !it test can be removed.
Comment 4 Ryan Jones 2006-09-22 11:47:41 PDT
Created attachment 239684 [details] [diff] [review]
Patch v2

Whoops... my bad - should have looked what I was deleting there.
Comment 5 Wan-Teh Chang 2006-09-22 12:03:27 PDT
I checked in the fix on the NSS trunk (NSS 3.12).  Thanks
for the patch.

Checking in jar.c;
/cvsroot/mozilla/security/nss/lib/jar/jar.c,v  <--  jar.c
new revision: 1.4; previous revision: 1.3
done

Note You need to log in before you can comment on or make changes to this bug.