All users were logged out of Bugzilla on October 13th, 2018

Build without JS_HAS_XML_SUPPORT fails

VERIFIED FIXED

Status

()

VERIFIED FIXED
13 years ago
12 years ago

People

(Reporter: mqmq87, Assigned: crowderbt)

Tracking

Trunk
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

13 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040914 (not Googlebot)
Build Identifier: CVS js

A build without JS_HAS_XML_SUPPORT fails. This means only JS_VERSION == 160
is working.


Reproducible: Always

Steps to Reproduce:
1. Try to build js with -DJS_VERSION=150



Support for JS_VERSION < 150 is even more broken. I started to fix it,
but it turned out to be much work, and probably nobody will ever use it.
So I suggest instead removing all support for JS_VERSION < 148 (ECMA 3).
Less #if JS_HAS_* will make the code more readable.

JS_VERSION < 120 (at least) was already broken in Mozilla Classic.
(Reporter)

Comment 1

13 years ago
Created attachment 219359 [details] [diff] [review]
patch to make JS_VERSION=150 work
Attachment #219359 - Flags: review?(brendan)
(Reporter)

Comment 2

13 years ago
Created attachment 219360 [details] [diff] [review]
started work for JS_VERSION < 150, incomplete, will never be finished by me
Comment on attachment 219359 [details] [diff] [review]
patch to make JS_VERSION=150 work

Two issues:

* jspubtd.h should not include jsconfig.h, which is private.  The public API should be the same for any compile-time version.

* The jsproto.tbl #if JS_HAS_XML_SUPPORT is also problematic: JSProto_* enumerator values are part of the serialized data produced by the JS_XDR* APIs, which end up on disk in one's XUL FastLoad File.

The .c file changes look good.

/be
Brian, can you confirm this bug if real and update and land any needed patch? Thanks,

/be

Updated

12 years ago
Attachment #219359 - Flags: review?(brendan) → review?(crowder)
(Assignee)

Comment 5

12 years ago
Created attachment 259103 [details] [diff] [review]
only change necessary for trunk build to work

Brendan:  this is the only change I needed to make the trunk build work.
Assignee: general → crowder
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #259103 - Flags: review?(brendan)
(Assignee)

Comment 6

12 years ago
Comment on attachment 219359 [details] [diff] [review]
patch to make JS_VERSION=150 work

This seems to change more than is necessary to build.
Attachment #219359 - Flags: review?(crowder) → review-
Comment on attachment 259103 [details] [diff] [review]
only change necessary for trunk build to work

Great -- thanks!

/be
Attachment #259103 - Flags: review?(brendan) → review+
(Assignee)

Comment 8

12 years ago
jsscan.c: 3.123

Please re-open this if you continue to have build issues.  Perhaps some difference between Linux and Mac OS X is causing me to see different build complaints than you are.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Comment 9

12 years ago
verified fixed trunk linux for -DJS_VERSION=150 
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.