nssCKFWCryptoOperation_UpdateCombo is not declared

RESOLVED FIXED in 3.12

Status

NSS
Libraries
P2
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: Julien Pierre, Assigned: Julien Pierre)

Tracking

unspecified
3.12

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

11 years ago
I wish there was a way to get the compiler to treat this as a build error rather than a warning. ckfw/session.c references this function without a prototype. This can wreak havoc on some architectures depending on the type assumptions made by the compiler. Patch forthcoming.
(Assignee)

Updated

11 years ago
Priority: -- → P2
Target Milestone: --- → 3.12
(Assignee)

Comment 1

11 years ago
Created attachment 219398 [details] [diff] [review]
declare function
Assignee: nobody → julien.pierre.bugs
Status: NEW → ASSIGNED
Attachment #219398 - Flags: review?(rrelyea)

Comment 2

11 years ago
GCC has the -Werror-implicit-function-declaration flag,
which is what you wanted.  In fact I was planning to suggest
that we use this flag.

Updated

11 years ago
Attachment #219398 - Flags: review?(rrelyea) → review+
I second that motion!  
use -Werror-implicit-function-declaration, at least on 64-bit builds.
(Assignee)

Comment 4

11 years ago
Thanks for the review, Wan-Teh. I agree that we should use that gcc flag on all the platforms that have it. Has it been available in gcc for a long time or is it a recent addition ?

Checking in ckfw.h;
/cvsroot/mozilla/security/nss/lib/ckfw/ckfw.h,v  <--  ckfw.h
new revision: 1.9; previous revision: 1.8
done
Checking in crypto.c;
/cvsroot/mozilla/security/nss/lib/ckfw/crypto.c,v  <--  crypto.c
new revision: 1.3; previous revision: 1.2
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED

Updated

11 years ago
Attachment #219398 - Flags: superreview+

Comment 5

11 years ago
Julien,

I found -Werror-implicit-function-declaration documented in
the oldest version of GCC (2.95.3) on the GCC documentation site:
http://gcc.gnu.org/onlinedocs/

See http://gcc.gnu.org/onlinedocs/gcc-2.95.3/gcc_2.html#SEC8,
search for "-Werror-implicit-function-declaration".

So it should be safe to just use this flag whenever we compile
with GCC.
You need to log in before you can comment on or make changes to this bug.