335053 - add assertions that we don't execute script during frame construction, reflow or painting

Status: NEW

(Core :: Layout, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We need to add assertions that we don't execute script during frame construction, reflow, or painting, since scripts can trigger frame construction, reflow, or painting, but often don't.  This would catch more quickly the problems that could cause the assertions added in bug 310985.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Note that we should also do this for things that might execute script -- in particular, firing events.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

This is a patch for this bug and bug 335054.

Need to get bugs filed on the assertions this shows.

Comment 3

[Mike Connor [:mconnor]]

punting remaining a6 bugs to b1, all of these shipped in a5, so we're at least no worse off by doing so.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Merged to trunk.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Bug 397954 may have some additional things we should assert on listed in it.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Dropping this from the 1.9 blocker list at this point.

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

How is this related to sicking's script blocker stuff?

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

I think these assertions and the assertions i've added will uncover many of the same bugs.

There is a big overlap between when the two will assert, but there are also things one will catch that the other won't.

For example all mutation-observer notifications will happen while we have script blocker so we can't assert there. But the assertions for not firing events while we have script blockers will catch things other than when layout code causes events to fire.