335183 - Sunbird's view controller doesn't handle recurring events properly

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Joey Minta]

Compare http://lxr.mozilla.org/mozilla/source/calendar/lightning/content/calendar-management.js#190 and http://lxr.mozilla.org/mozilla/source/calendar/resources/content/calendarWindow.js#74

Comment 1

[Joey Minta]

Attachment: add extra check

Adds extra case.  Corrects errors when modifying an instance and then choosing 'All occurrences'.

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

Comment on attachment 219923 [details] [diff] [review]
add extra check

>Index: calendar/resources/content/calendarWindow.js
>+            aNewStartTime.addDuration(startDiff);
In general, assigning to aFoo isn't nice. At first, i thought the if-block didn't do anything, bacause you still use aNewStartTime after.

r=mvl with some variable juggling, so that you don't assign to aFoo.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Took the liberty of checking in this patch.