Closed Bug 335183 Opened 14 years ago Closed 14 years ago

Sunbird's view controller doesn't handle recurring events properly

Categories

(Calendar :: Sunbird Only, defect)

Product:
Calendar
Component:
Sunbird Only
Type:
defect
Priority:
Not set

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jminta, Assigned: jminta)

References

Details

Attachments

(1 file)

add extra check
1.55 KB, patch
mvl
: first-review+
Details | Diff | Splinter Review
Attached patch add extra check — — Splinter Review 
Adds extra case.  Corrects errors when modifying an instance and then choosing 'All occurrences'.
Assignee: nobody → jminta
Status: NEW → ASSIGNED
Attachment #219923 - Flags: first-review?(mvl)
Comment on attachment 219923 [details] [diff] [review]
add extra check

>Index: calendar/resources/content/calendarWindow.js
>+            aNewStartTime.addDuration(startDiff);
In general, assigning to aFoo isn't nice. At first, i thought the if-block didn't do anything, bacause you still use aNewStartTime after.

r=mvl with some variable juggling, so that you don't assign to aFoo.
Attachment #219923 - Flags: first-review?(mvl) → first-review+
Took the liberty of checking in this patch.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.